[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdemultimedia/noatun/library
From:       Stefan Gehn <mETz81 () web ! de>
Date:       2007-02-01 14:15:13
Message-ID: 1170339313.943986.10635.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 629123 by metz:

- Only change current item if placback engine supports playing that item \
                (EngineInterface::play(url) has to return true)
- apidocs


 D             DESIGN  
 A             Design.dox   DESIGN#629080
 M  +5 -4      Mainpage.dox  
 M  +2 -1      noatun/plugininterfaces.h  
 M  +10 -5     player.cpp  


--- trunk/KDE/kdemultimedia/noatun/library/Mainpage.dox #629122:629123
@@ -1,23 +1,24 @@
 /**
  * @mainpage Noatun Library Documentation
  *
- * \section sec_plugin Plugin Writing Basics
+ * @section sec_plugin Plugin Writing Basics
  * If you're interested in writing plugins you should probably
  * check out Noatun::Interface and its subclasses for all the possible ways
  * to extend Noatun via plugins.
  *
  * TODO: Plugin example with skeleton code
  *
- * \section sec_frontend Writing Frontends
+ * @section sec_frontend Writing Frontends
  * Some pages of interest for mainwindow-plugin authors
  * - Noatun::FrontendInterface
  * - Noatun::NMainWindow
  * - Noatun::StdAction
  *
- * \section sec_playlist Writing Playlists
+ * @section sec_playlist Writing Playlists
  * Some pages of interest for playlist-plugin authors
  * - Noatun::PlaylistInterface
  * - Noatun::ItemSourceInterface
-**/
+ *
+ **/
 // DOXYGEN_PROJECTNAME = libnoatun
 // DOXYGEN_EXCLUDE = noatuntags
--- trunk/KDE/kdemultimedia/noatun/library/noatun/plugininterfaces.h #629122:629123
@@ -796,7 +796,7 @@
 /**
  * Implement this interface if your plugin is a playlist.
  *
- * \todo get rid of this class
+ * @todo add methods for implementing loop-modes
  **/
 class NOATUN_EXPORT ItemSourceInterface : public Interface
 {
@@ -815,6 +815,7 @@
  * Implement this if your plugin is a playback backend.
  *
  * @todo Check if API can support gapless/crossfading playback easily
+ * @todo Add support for effects, most notably an equalizer
  **/
 class NOATUN_EXPORT EngineInterface : public Interface
 {
--- trunk/KDE/kdemultimedia/noatun/library/player.cpp #629122:629123
@@ -146,11 +146,16 @@
 	{
 		stop();
 		kDebug(66666) << k_funcinfo << "Starting to play new current track" << endl;
-		d->currentItem = item;
-		d->itemSource->setCurrent(item); //TODO: why do we have a "current" item in two \
                places?
-		d->engine->play(d->currentItem.url());
-
-		emit currentItemChanged(d->currentItem);
+		if (d->engine->play(item.url()))
+		{
+			d->currentItem = item;
+			d->itemSource->setCurrent(item); //TODO: why do we have a "current" item in two \
places? +			emit currentItemChanged(d->currentItem);
+		}
+		else
+		{
+			// TODO: this situation is probably similar to engineErrorOccurred()
+		}
 	}
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]