[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: playground/utils/dolphin/src
From:       David Faure <faure () kde ! org>
Date:       2007-01-25 20:31:22
Message-ID: 200701252131.23055.faure () kde ! org
[Download RAW message or body]

On Thursday 25 January 2007 20:37, Peter Penz wrote:
> +
> +bool DolphinMainWindow::UndoUiInterface::copiedFileWasModified(const KUrl& src,
> +                                                               const KUrl& dest,
> +                                                               time_t /*srcTime*/,
> +                                                               time_t destTime)
> +{
> +    // The following code has been taken from libkonq/konq_undo.cc

You should tell me when my APIs suck ;-)
Code duplication is no good. I'll expose the default UiInterface implementation, instead.

It's cool that UiInterface is useful for dolphin ;) I only wrote it with the unit test in mind,
to allow to return true in the above method without a msgbox popping up.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]