[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: extragear/graphics/kst/src
From: Barth Netterfield <netterfield () astro ! utoronto ! ca>
Date: 2007-01-19 13:56:04
Message-ID: 1169214964.662480.8526.nullmailer () svn ! kde ! org
[Download RAW message or body]
SVN commit 625207 by netterfield:
Default parameters can sometimes be evil...
so: get rid of the default, and require explicit edit/new parameters
for each call to showDialog.
BUG: 140208
M +1 -1 libkstapp/kst.cpp
M +1 -1 libkstapp/kst2dplot.cpp
M +1 -1 libkstapp/ksttoplevelview.cpp
M +2 -2 libkstapp/kstviewmanager_i.cpp
M +1 -1 libkstapp/kstviewobject.cpp
M +1 -1 libkstapp/kstviewobject.h
M +1 -1 libkstmath/kstdataobject.h
--- trunk/extragear/graphics/kst/src/libkstapp/kst.cpp #625206:625207
@@ -1017,7 +1017,7 @@
if ( newPlugins.contains( p ) ) {
KstDataObjectPtr ptr = KstDataObject::plugin(p);
- ptr->showDialog();
+ ptr->showDialog(true);
} else if ( oldPlugins.contains( p ) ) {
KstPluginDialogI::globalInstance()->showNew(readable[p]);
}
--- trunk/extragear/graphics/kst/src/libkstapp/kst2dplot.cpp #625206:625207
@@ -3243,7 +3243,7 @@
KstBaseCurvePtr curve = *(Curves.findTag(_curveEditMap[id]));
if (curve) {
curve->readLock();
- curve->showDialog();
+ curve->showDialog(true);
curve->unlock();
}
}
--- trunk/extragear/graphics/kst/src/libkstapp/ksttoplevelview.cpp #625206:625207
@@ -1722,7 +1722,7 @@
bool KstTopLevelView::handleDoubleClick(const QPoint& pos, bool shift) {
handlePress(pos, shift);
if (_pressTarget) {
- _pressTarget->showDialog(this);
+ _pressTarget->showDialog(this, false);
}
return true;
}
--- trunk/extragear/graphics/kst/src/libkstapp/kstviewmanager_i.cpp #625206:625207
@@ -528,13 +528,13 @@
} else if (qi->rtti() == RTTI_OBJ_VIEW_OBJECT) {
KstViewObjectPtr obj = koi->viewObject(&win);
if (obj && win) {
- obj->showDialog(win->view());
+ obj->showDialog(win->view(), false);
}
} else if (qi->rtti() == RTTI_OBJ_DATA_OBJECT) {
Kst2DPlotPtr plot;
KstDataObjectPtr obj = koi->dataObject(plot);
if (obj) {
- obj->showDialog();
+ obj->showDialog(true);
}
}
} else {
--- trunk/extragear/graphics/kst/src/libkstapp/kstviewobject.cpp #625206:625207
@@ -1271,7 +1271,7 @@
void KstViewObject::edit() {
KstTopLevelViewPtr tlv = \
kst_cast<KstTopLevelView>(KstViewObjectPtr(_topObjectForMenu));
- showDialog(tlv);
+ showDialog(tlv, false);
}
--- trunk/extragear/graphics/kst/src/libkstapp/kstviewobject.h #625206:625207
@@ -267,7 +267,7 @@
virtual void zoomToggle();
virtual void copyObject();
virtual KstViewObject* copyObjectQuietly(KstViewObject& parent, const QString& \
name = QString::null) const;
- virtual bool showDialog(KstTopLevelViewPtr invoker, bool isNew = false);
+ virtual bool showDialog(KstTopLevelViewPtr invoker, bool isNew);
protected slots:
virtual void parentResized();
--- trunk/extragear/graphics/kst/src/libkstmath/kstdataobject.h #625206:625207
@@ -114,7 +114,7 @@
QString version() const { return _version; }
QString library() const { return _library; }
- void showDialog( bool edit = false );
+ void showDialog( bool edit );
protected slots:
virtual void showNewDialog() = 0;
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic