[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/kdevelop/3.4/languages/cpp
From:       Jens Dagerbo <jens.dagerbo () swipnet ! se>
Date:       2006-12-29 23:07:40
Message-ID: 1167433660.273669.16434.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 617686 by dagerbo:

it's hard to feel certain about anything in the cpp plugin, but it strikes me as \
prudent to lock the background parser before we add files to it. It also happens to \
fix a crash I'm getting...

 M  +6 -0      cppsupportpart.cpp  


--- branches/kdevelop/3.4/languages/cpp/cppsupportpart.cpp #617685:617686
@@ -2211,6 +2211,9 @@
 
 		kdDebug() << "reparsing the following group: " << ":\n" << group.join("\n") << \
"\n\n";  if( background ) {
+			
+			m_backgroundParser->lock();
+			
 			if( !group.isEmpty() ) {
 				if( !parseFirst )
 					m_parseEmitWaiting.addGroup( group, silent ? ParseEmitWaiting::Silent : \
ParseEmitWaiting::None  ); @@ -2240,6 +2243,9 @@
 					backgroundParser()->addFile(*it);
 				}
 			}
+			
+			m_backgroundParser->unlock();
+			
 		} else {
 			for(QStringList::iterator it = group.begin(); it != group.end(); ++it) {
 				if( !silent && _jd ) //If this this file is not silent and thus not part of the \
initial parse, increase the background-count so the progress-bar does not get \
confused


[prev in list] [next in list] [prev in thread] [next in thread]