[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/graphics/gwenview
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2006-11-06 11:56:22
Message-ID: 200611061256.22688.l.lunak () suse ! cz
[Download RAW message or body]

On Thursday 02 November 2006 00:35, Aurélien Gâteau wrote:
> SVN commit 601072 by gateau:
>
> parentWidget may be 0, better get toplevel widget from KApplication.
> BUG: 130379
>
>  	mDirLister = new KDirLister;
>  	mDirLister->setAutoErrorHandlingEnabled( false, 0 );
> -	mDirLister->setMainWindow( parentWidget->topLevelWidget());
> +	mDirLister->setMainWindow(KApplication::kApplication()->mainWidget());
>  	connect( mDirLister, SIGNAL( clear()), SLOT( dirListerClear()));
>  	connect( mDirLister, SIGNAL( newItems( const KFileItemList& )),
>  		SLOT( dirListerNewItems( const KFileItemList& )));

 If I'm not mistaken e.g. Konqueror doesn't have _the_ mainwindow, so in such 
case you've effectively set it to no parent. The code should probably be 
something like "parentWidget ? parentWidget->topLevelWidget() : 
kapp->mainWidget()".

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak@suse.cz , l.lunak@kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http//www.suse.cz

[prev in list] [next in list] [prev in thread] [next in thread]