[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdelibs/kjs
From:       Harri Porten <porten () kde ! org>
Date:       2006-11-04 20:51:13
Message-ID: 1162673473.768793.12826.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 601970 by porten:

Fixed toPrecision(n) calls on negative zero. First part of #136734.


 M  +4 -0      ChangeLog  
 M  +4 -3      number_object.cpp  


--- branches/KDE/3.5/kdelibs/kjs/ChangeLog #601969:601970
@@ -1,3 +1,7 @@
+2006-11-04  Harri Porten  <porten@kde.org>
+
+	* number_object.cpp: Fixed toPrecision(n) calls on negative zero.
+
 2005-09-17  Harri Porten  <porten@kde.org>
 
 	* date_object.cpp: MSVC equivalent for strncasecmp().
--- branches/KDE/3.5/kdelibs/kjs/number_object.cpp #601969:601970
@@ -93,11 +93,12 @@
 static UString integer_part_noexp(double d)
 {
   int decimalPoint;
-  int sign;
-  char *result = kjs_dtoa(d, 0, 0, &decimalPoint, &sign, NULL);
+  int signDummy;
+  char *result = kjs_dtoa(d, 0, 0, &decimalPoint, &signDummy, NULL);
   int length = strlen(result);
 
-  UString str = sign ? "-" : "";
+  // sign for non-zero, negative numbers
+  UString str = d < 0 ? "-" : "";
   if (decimalPoint == 9999) {
     str += UString(result);
   } else if (decimalPoint <= 0) {
[prev in list] [next in list] [prev in thread] [next in thread]