[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/runtime/kioslave/trash
From:       David Faure <faure () kde ! org>
Date:       2006-10-31 23:43:09
Message-ID: 200611010043.10635.faure () kde ! org
[Download RAW message or body]

On Wed Nov 1 2006, David Faure wrote:
> On Wed Nov 1 2006, David Faure wrote:
> > SVN commit 600835 by dfaure:
> > 
> > Factor out the code that determines the id for a given device.
> > Still can't believe that the unit tests pass - the code doesn't actually seem to \
> > be called :/
> 
> Ah I know why. The partition containing $HOME is special cased (as id=0)
> and the partition containing "/tmp" doesn't have a special trash dir by default, so \
> it gets trashed to 0 too. Need to create an actual trash dir on some other \
> partition first...

Doesn't work. Solid is on crack ;)

testtrash: topdir=/media/XO-Y4
testtrash: topdir=/home
testtrash: topdir=/foreign
testtrash: topdir=/

Wow !!!
I never had anything called /foreign or /media/XO-Y4, and on the other hand some \
mount points are missing. "mount" says:
/dev/sda3 on / type ext3 (rw,errors=remount-ro)
/dev/sda5 on /d type ext3 (rw)
/dev/sda7 on /home type ext3 (rw)
/dev/sda2 on /media/sda2 type vfat (rw,utf8,umask=007,gid=46)
/dev/sda1 on /mnt/windows type ntfs (rw,nls=utf8,umask=007,gid=46)

--- trashimpl.cpp       (revision 600835)
+++ trashimpl.cpp       (working copy)
@@ -759,6 +759,7 @@ void TrashImpl::scanTrashDirectories() c
                                                                               \
                "Volume.mounted == true");
     for ( Solid::DeviceList::Iterator it = lst.begin() ; it != lst.end() ; ++it ) {
         QString topdir = (*it).as<Solid::Volume>()->mountPoint();
+        kDebug() << "topdir=" << topdir << endl;
         QString trashDir = trashForMountPoint( topdir, false );
         if ( !trashDir.isEmpty() ) {
             // OK, trashDir is a valid trash directory. Ensure it's registered.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


[prev in list] [next in list] [prev in thread] [next in thread]