[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/3.5/kdepim/korganizer
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2006-10-30 9:19:14
Message-ID: 200610301019.22723.dfaure () klaralvdalens-datakonsult ! se
[Download RAW message or body]

On Mon Oct 30 2006, Allen Winter wrote:
> On Sunday, October 29, 2006 03:57:50 PM Bram Schoenmakers wrote:
> > SVN commit 600193 by bram:
> > 
> > Bugfix: with the Copy To submenu, a todo does have a due date set. This didn't \
> > work in case the source todo had no due date set. 
> > 
> > 
> > M  +3 -2      kotodoview.cpp  
> > 
> > 
> > --- branches/KDE/3.5/kdepim/korganizer/kotodoview.cpp #600192:600193
> > @@ -925,8 +925,7 @@
> > 
> > void KOTodoView::copyTodoToDate( QDate date )
> > {
> > -  QDateTime dt;
> > -  dt.setDate( date );
> > +  QDateTime dt( date );
> > 
> > if ( mActiveItem && mChanger ) {
> > Todo *newTodo = mActiveItem->todo()->clone();
> > @@ -934,6 +933,8 @@
> > 
> > if ( date.isNull() )
> > newTodo->setHasDueDate( false );
> > +
> > +   newTodo->setHasDueDate( true );
> 
> ^this doesn't look correct to me.  Should the code read:
> if(date.isNull()) {
> newTodo->setHasDueDate(false);
> } else {
> newTodo->setHadDueDate(true);
> }
or 
newTodo->setHasDueDate( !date.isNull() ) 
> )

-- 
David Faure, faure@kde.org, dfaure@klaralvdalens-datakonsult.se
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions


[prev in list] [next in list] [prev in thread] [next in thread]