[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdelibs/kio/kio
From:       David Faure <faure () kde ! org>
Date:       2006-10-26 8:35:48
Message-ID: 1161851748.688661.9609.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 599200 by dfaure:

Patch from Modestas Vainius <geromanas mailas.com> to fix Bug 122020 (kdesvnd action menu issues)
He said, and I agree:

Do not time out when waiting for the reply for the X-KDE-GetActionMenu DCOP
call. DCOP protocol is synchronouos by design and a reply for the timed out
call (i.e. garbage) still arrives and might be falsely returned as a valid
reply for the subsequent DCOP call on the same connection. The application
currently known to be badly hurt by this is kdesvn and its konqueror service
menu integration. Its X-KDE-GetActionMenu might take longer than current 100
milisecond timeout to complete. As a result then, a late reply will "pollute" a
main DCOP connection of the client application (e.g. konqueror) causing further
DCOP failures.


 M  +1 -1      kmimetype.cpp  


--- branches/KDE/3.5/kdelibs/kio/kio/kmimetype.cpp #599199:599200
@@ -1013,7 +1013,7 @@
     } else {
       if(kapp->dcopClient()->call( app, object,
                    function.utf8(),
-                   dataToSend, replyType, replyData, true, 100)
+                   dataToSend, replyType, replyData, true, -1)
 	    && replyType == "QStringList" ) {
 
         QDataStream dataStreamIn(replyData, IO_ReadOnly);
[prev in list] [next in list] [prev in thread] [next in thread]