[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/3.5/kdepim/libkmime
From:       Allen Winter <winter () kde ! org>
Date:       2006-10-19 21:33:55
Message-ID: 200610191733.56173.winter () kde ! org
[Download RAW message or body]

On Thursday, October 19, 2006 04:48:16 PM Tom Albers wrote:
> SVN commit 597297 by toma:
> 
> Adds the UserAgent header to the assemble() method. To work, I moved the userAgent( \
> bool ) method from newsarticle to message. newsarticle inherits message so no \
> problems expected....  
> 
> M  +4 -0      kmime_message.cpp  
> M  +1 -0      kmime_message.h  
> M  +0 -1      kmime_newsarticle.h  
> 
Hi Tom,

Are your libkmime fixes forward port-able to trunk?
If so, can you do the ports please?
-Allen

 
> 
> --- branches/KDE/3.5/kdepim/libkmime/kmime_message.cpp #597296:597297
> @@ -82,6 +82,10 @@
> if( (h=organization(false))!=0 )
> newHead+=h->as7BitString()+"\n";
> 
> +  //UserAgent
> +  if( (h=userAgent(false))!=0 )
> +    newHead+=h->as7BitString()+"\n";
> +
> //Mime-Version
> newHead+="MIME-Version: 1.0\n";
> 
> --- branches/KDE/3.5/kdepim/libkmime/kmime_message.h #597296:597297
> @@ -51,6 +51,7 @@
> virtual KMime::Headers::CC* cc(bool create=true)                      { \
> KMime::Headers::CC *p=0; return getHeaderInstance(p, create); } virtual \
> KMime::Headers::BCC* bcc(bool create=true)                    { KMime::Headers::BCC \
> *p=0; return getHeaderInstance(p, create); } virtual KMime::Headers::References* \
> references(bool create=true)      { KMime::Headers::References *p=0; return \
> getHeaderInstance(p, create); } +  virtual KMime::Headers::UserAgent* \
> userAgent(bool create=true)        { KMime::Headers::UserAgent *p=0; return \
> getHeaderInstance(p, create); } 
> protected:
> //hardcoded headers
> --- branches/KDE/3.5/kdepim/libkmime/kmime_newsarticle.h #597296:597297
> @@ -43,7 +43,6 @@
> virtual KMime::Headers::Newsgroups* newsgroups(bool create=true)      { \
> KMime::Headers::Newsgroups *p=0; return getHeaderInstance(p, create); } virtual \
> KMime::Headers::FollowUpTo* followUpTo(bool create=true)      { \
> KMime::Headers::FollowUpTo *p=0; return getHeaderInstance(p, create); } virtual \
> KMime::Headers::Lines* lines(bool create=true)                { if(!create && \
>                 l_ines.isEmpty()) return 0; return &l_ines; }
> -  virtual KMime::Headers::UserAgent* userAgent(bool create=true)        { \
> KMime::Headers::UserAgent *p=0; return getHeaderInstance(p, create); } 
> 
> protected:
> 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]