[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdenetwork/kopete/libkopete
From:       Dirk Mueller <mueller () kde ! org>
Date:       2006-10-13 12:55:32
Message-ID: 1160744132.482287.27692.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 595163 by mueller:

I don't quite understand how, but the iterator
tends to become invalid, and then it crashes.
optimizing memory and stability and the same time :)


 M  +2 -3      kopetemessagehandler.cpp  


--- branches/KDE/3.5/kdenetwork/kopete/libkopete/kopetemessagehandler.cpp #595162:595163
@@ -76,7 +76,6 @@
 {
 public:
 	static FactoryList &factories();
-	FactoryList::Iterator iterator;
 };
 
 MessageHandlerFactory::FactoryList &MessageHandlerFactory::Private::factories()
@@ -91,12 +90,12 @@
 MessageHandlerFactory::MessageHandlerFactory()
 	: d( new Private )
 {
-	d->iterator = Private::factories().append(this);
+	Private::factories().append(this);
 }
 
 MessageHandlerFactory::~MessageHandlerFactory()
 {
-	Private::factories().remove( d->iterator );
+	Private::factories().remove( this );
 	delete d;
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]