[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/khtml/rendering
From:       Stephan Kulow <coolo () kde ! org>
Date:       2006-10-07 13:37:20
Message-ID: 200610071537.22725.coolo () kde ! org
[Download RAW message or body]

Am Samstag, 7. Oktober 2006 14:00 schrieb André Wöbbeking:
> On Saturday 07 October 2006 12:40, Stephan Kulow wrote:
> > SVN commit 593249 by coolo:
> >
> > perhaps more clear
> >
> >
> >  M  +1 -1      render_line.cpp
> >
> >
> > --- trunk/KDE/kdelibs/khtml/rendering/render_line.cpp #593248:593249
> > @@ -230,7 +230,7 @@
> >
> >      RenderObject* curr = endObject;
> >      RenderObject* parent = curr->parent();
> > -    while (parent && !parent->isRenderBlock() || parent == object())
> > { +    while (parent && (!parent->isRenderBlock() || parent ==
> > object())) { if (parent->lastChild() != curr)
> >              return false;
>
> perhape more clear but wrong as you changed the evaluation order (&& has
> higher priority than ||).

That was the point behind this change. If object() would return 0 (the only 
case where the evaluation order makes a difference), the next line would 
crash.

Greetings, Stephan

[prev in list] [next in list] [prev in thread] [next in thread]