[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdeprint
From:       Adriaan de Groot <groot () kde ! org>
Date:       2006-10-01 14:52:57
Message-ID: 1159714377.810681.7264.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 591039 by adridg:

EBN: make constructors that take one argument (or one + those with default values) \
explicit to avoid sneaky conversions. Patch from Robert Scott

 M  +1 -1      cups/cupsdconf2/qdirlineedit.h  
 M  +1 -1      cups/kcupsprinterimpl.h  
 M  +1 -1      cups/kptextpage.h  
 M  +1 -1      kmspecialmanager.h  
 M  +1 -1      kprintaction.h  
 M  +1 -1      kprintdialogpage.h  
 M  +1 -1      lpr/apshandler.h  
 M  +1 -1      lpr/lprhandler.h  
 M  +1 -1      management/cjanuswidget.h  
 M  +1 -1      management/jobitem.h  
 M  +1 -1      management/kiconselectaction.h  
 M  +1 -1      management/kmwsocketutil.h  
 M  +1 -1      marginvaluewidget.h  


--- trunk/KDE/kdelibs/kdeprint/cups/cupsdconf2/qdirlineedit.h #591038:591039
@@ -30,7 +30,7 @@
 {
 	Q_OBJECT
 public:
-	QDirLineEdit(bool file, QWidget *parent = 0);
+	explicit QDirLineEdit(bool file, QWidget *parent = 0);
 	~QDirLineEdit();
 
 	void setUrl(const QString& txt);
--- trunk/KDE/kdelibs/kdeprint/cups/kcupsprinterimpl.h #591038:591039
@@ -25,7 +25,7 @@
 class KCupsPrinterImpl : public KPrinterImpl
 {
 public:
-	KCupsPrinterImpl(QObject *parent, const QStringList & /*args*/ = QStringList());
+	explicit KCupsPrinterImpl(QObject *parent, const QStringList & /*args*/ = \
QStringList());  ~KCupsPrinterImpl();
 
 	bool setupCommand(QString&, KPrinter*);
--- trunk/KDE/kdelibs/kdeprint/cups/kptextpage.h #591038:591039
@@ -32,7 +32,7 @@
 {
 	Q_OBJECT
 public:
-	KPTextPage(DrMain *driver, QWidget *parent = 0);
+	explicit KPTextPage(DrMain *driver, QWidget *parent = 0);
 	~KPTextPage();
 
 	void setOptions(const QMap<QString,QString>& opts);
--- trunk/KDE/kdelibs/kdeprint/kmspecialmanager.h #591038:591039
@@ -31,7 +31,7 @@
 class KMSpecialManager : public QObject
 {
 public:
-	KMSpecialManager(KMManager *parent);
+	explicit KMSpecialManager(KMManager *parent);
 
 	bool loadPrinters();
 	bool savePrinters();
--- trunk/KDE/kdelibs/kdeprint/kprintaction.h #591038:591039
@@ -30,7 +30,7 @@
 public:
 	enum PrinterType { All, Regular, Specials };
 
-	KPrintAction(const QString& text, PrinterType type = All, QWidget *parentWidget = \
0, KActionCollection *parent = 0, const char *name = 0); +	explicit \
KPrintAction(const QString& text, PrinterType type = All, QWidget *parentWidget = 0, \
KActionCollection *parent = 0, const char *name = 0);  KPrintAction(const KIcon& \
icon, const QString& text, PrinterType type = All, QWidget *parentWidget = 0, \
KActionCollection *parent = 0, const char *name = 0);  virtual ~KPrintAction();
 
--- trunk/KDE/kdelibs/kdeprint/kprintdialogpage.h #591038:591039
@@ -98,7 +98,7 @@
 	/**
 	 * Modified constructor. For internal use only.
 	 */
-	KPrintDialogPage(KMPrinter *pr, DrMain *dr = 0, QWidget *parent = 0);
+	explicit KPrintDialogPage(KMPrinter *pr, DrMain *dr = 0, QWidget *parent = 0);
 	/**
 	 * Destructor
 	 */
--- trunk/KDE/kdelibs/kdeprint/lpr/apshandler.h #591038:591039
@@ -27,7 +27,7 @@
 class ApsHandler : public LprHandler
 {
 public:
-	ApsHandler(KMManager*);
+	explicit ApsHandler(KMManager*);
 
 	bool validate(PrintcapEntry*);
 	KMPrinter* createPrinter(PrintcapEntry*);
--- trunk/KDE/kdelibs/kdeprint/lpr/lprhandler.h #591038:591039
@@ -42,7 +42,7 @@
 class LprHandler
 {
 public:
-	LprHandler(const QString& name, KMManager *mgr = 0);
+	explicit LprHandler(const QString& name, KMManager *mgr = 0);
 	virtual ~LprHandler();
 
 	virtual bool validate(PrintcapEntry*);
--- trunk/KDE/kdelibs/kdeprint/management/cjanuswidget.h #591038:591039
@@ -32,7 +32,7 @@
 {
 	Q_OBJECT
 public:
-	CJanusWidget(QWidget *parent);
+	explicit CJanusWidget(QWidget *parent);
 	~CJanusWidget();
 
 	void addPage(QWidget *w, const QString& text, const QString& header, const QPixmap& \
                pix);
--- trunk/KDE/kdelibs/kdeprint/management/jobitem.h #591038:591039
@@ -28,7 +28,7 @@
 class JobItem : public QTreeWidgetItem, public KMObject
 {
 public:
-	JobItem(QTreeWidget *parent, KMJob *job = 0);
+	explicit JobItem(QTreeWidget *parent, KMJob *job = 0);
 	~JobItem();
 	void init(KMJob *job);
 	virtual bool operator <(const QTreeWidgetItem &other) const;
--- trunk/KDE/kdelibs/kdeprint/management/kiconselectaction.h #591038:591039
@@ -26,7 +26,7 @@
 {
 	Q_OBJECT
 public:
-	KIconSelectAction(const QString& text, KActionCollection* parent = 0, const char* \
name = 0); +	explicit KIconSelectAction(const QString& text, KActionCollection* \
parent = 0, const char* name = 0);  virtual ~KIconSelectAction();
 
 public Q_SLOTS:
--- trunk/KDE/kdelibs/kdeprint/management/kmwsocketutil.h #591038:591039
@@ -42,7 +42,7 @@
 	friend class KMWSocketUtil;
 	Q_OBJECT
 public:
-	SocketConfig(KMWSocketUtil *util, QWidget *parent = 0, const char *name = 0);
+	explicit SocketConfig(KMWSocketUtil *util, QWidget *parent = 0, const char *name = \
0);  ~SocketConfig();
 
 protected Q_SLOTS:
--- trunk/KDE/kdelibs/kdeprint/marginvaluewidget.h #591038:591039
@@ -27,7 +27,7 @@
 	Q_OBJECT
 public:
 	enum Mode { Pixels = 0, IN, CM, MM };
-	MarginValueWidget(KNumInput *below, double value = 18.0, QWidget *parent = 0);
+	explicit MarginValueWidget(KNumInput *below, double value = 18.0, QWidget *parent = \
0);  
 	float margin();
 	int resolution() const;


[prev in list] [next in list] [prev in thread] [next in thread]