[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kjs
From:       Harri Porten <porten () kde ! org>
Date:       2006-09-30 22:28:50
Message-ID: 1159655330.215858.12369.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 590807 by porten:

*really* stay inside the portable mktime(). I have not fully analyzed the
problem but it seems like (new Date(0)).setFullYear(1970, 0, 1) went
outside. Maybe due to my time zone?


 M  +1 -3      date_object.cpp  


--- trunk/KDE/kdelibs/kjs/date_object.cpp #590806:590807
@@ -683,8 +683,6 @@
 
 // ------------------------------ DateObjectImp --------------------------------
 
-// TODO: MakeTime (15.9.11.1) etc. ?
-
 DateObjectImp::DateObjectImp(ExecState *exec,
                              FunctionPrototype *funcProto,
                              DatePrototype *dateProto)
@@ -889,7 +887,7 @@
     }
 
     double yearOffset = 0.0;
-    if (t->tm_year < (1970 - 1900) || t->tm_year > (2038 - 1900)) {
+    if (t->tm_year < (1971 - 1900) || t->tm_year > (2037 - 1900)) {
         // we'll fool mktime() into believing that this year is within
         // its normal, portable range (1970-2038) by setting tm_year to
         // 2000 or 2001 and adding the difference in milliseconds later.
[prev in list] [next in list] [prev in thread] [next in thread]