[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdenetwork/kppp
From:       Thomas Häber <thomas () haeber ! de>
Date:       2006-09-27 23:38:00
Message-ID: 1159400280.286032.3989.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 589329 by haeber:

changed single chars from QString to QChar in add to QString context -> faster (EBN)

 M  +4 -4      accounting.cpp  
 M  +1 -1      accounts.cpp  
 M  +1 -1      acctselect.cpp  
 M  +9 -9      connect.cpp  
 M  +2 -2      conwindow.cpp  
 M  +1 -1      edit.cpp  
 M  +3 -3      logview/export.cpp  
 M  +1 -1      modems.cpp  
 M  +1 -1      providerdb.cpp  


--- trunk/KDE/kdenetwork/kppp/accounting.cpp #589328:589329
@@ -290,9 +290,9 @@
     start_time = time(0);
     QString s;
     s = timet2qstring(start_time);
-    s += ":";
+    s += ':';
     s += gpppdata.accname();
-    s += ":";
+    s += ':';
     s += rules.currencySymbol();
 
     logMessage(s, TRUE);
@@ -449,9 +449,9 @@
 
   time_t start_time = time(0);
   s = timet2qstring(start_time);
-  s += ":";
+  s += ':';
   s += gpppdata.accname();
-  s += ":";
+  s += ':';
   s += currency;
 
   logMessage(s, TRUE);
--- trunk/KDE/kdenetwork/kppp/accounts.cpp #589328:589329
@@ -460,7 +460,7 @@
     n1 = n1 / 1024.0;
 
   QString s = KGlobal::locale()->formatNumber( n1, idx==0 ? 0 : 1 );
-  s += " " + quant[idx];
+  s += ' ' + quant[idx];
   return s;
 }
 
--- trunk/KDE/kdenetwork/kppp/acctselect.cpp #589328:589329
@@ -300,7 +300,7 @@
     Q3ListViewItem* i = tl->currentItem();
     QString s;
     while(i) {
-      s = "/" + i->text(0) + s;
+      s = '/' + i->text(0) + s;
       i = i->parent();
     }
     selected->setText(s.mid(1));
--- trunk/KDE/kdenetwork/kppp/connect.cpp #589328:589329
@@ -615,7 +615,7 @@
 	  scriptarg = scriptArgument;
 	else {
 	  for(int i = 0; i < scriptArgument.length(); i++)
-	    scriptarg += "*";
+	    scriptarg += '*';
 	}
 	QString bm = i18n("Sending %1", scriptarg);
 
@@ -1272,20 +1272,20 @@
   //  command += " ";
   //  command += gpppdata.modemDevice();
 
-  command += " " + gpppdata.speed();
+  command += ' ' + gpppdata.speed();
 
   command += " -detach";
 
   if(gpppdata.ipaddr() != "0.0.0.0" ||
      gpppdata.gateway() != "0.0.0.0") {
     if(gpppdata.ipaddr() != "0.0.0.0") {
-      command += " ";
+      command += ' ';
       command += gpppdata.ipaddr();
-      command +=  ":";
+      command += ':';
     }
     else {
-      command += " ";
-      command += ":";
+      command += ' ';
+      command += ':';
     }
 
     if(gpppdata.gateway() != "0.0.0.0")
@@ -1317,7 +1317,7 @@
         it != arglist.end();
         ++it )
   {
-    command += " " + *it;
+    command += ' ' + *it;
   }
 
   // Callback settings
@@ -1458,7 +1458,7 @@
 	  write(fd, tmp, tmp.length());
 	}
 	else {
-	  Q3CString tmp = resolv[j].toLocal8Bit() + "\n";
+	  Q3CString tmp = resolv[j].toLocal8Bit() + '\n';
 	  write(fd, tmp, tmp.length());
 	}
       }
@@ -1538,7 +1538,7 @@
 	  write(fd, "\n", 1);
 	}
 	else {
-	  Q3CString tmp = resolv[j].toLocal8Bit() + "\n";
+	  Q3CString tmp = resolv[j].toLocal8Bit() + '\n';
 	  write(fd, tmp, tmp.length());
 	}
       }
--- trunk/KDE/kdenetwork/kppp/conwindow.cpp #589328:589329
@@ -117,7 +117,7 @@
     n1 = n1 / 1024.0;
 
   QString s = KGlobal::locale()->formatNumber( n1, idx==0 ? 0 : 1 );
-  s += " " + quant[idx];
+  s += ' ' + quant[idx];
   return s;
 }
 
@@ -314,7 +314,7 @@
     time_string2.sprintf("%02d:%02d:%02d",hours,minutes,seconds);
 
   caption_string = gpppdata.accname();
-  caption_string += " ";
+  caption_string += ' ';
   caption_string += time_string;
 
 
--- trunk/KDE/kdenetwork/kppp/edit.cpp #589328:589329
@@ -233,7 +233,7 @@
     QString number = "";
     for(uint i = 0; i < numbers->count(); i++) {
       if(i != 0)
-	number += ":";
+	number += ':';
       number += numbers->text(i);
     }
 
--- trunk/KDE/kdenetwork/kppp/logview/export.cpp #589328:589329
@@ -132,9 +132,9 @@
   if ( i == -1 )
       return;
   // prepare filter: e.g.: HTML (*.html *.HTML)
-  QString filter = "*." + ExportFormats[i].ext + " *." + \
ExportFormats[i].ext.toUpper() + "|" + +  QString filter = "*." + \
                ExportFormats[i].ext + " *." + ExportFormats[i].ext.toUpper() + '|' +
                    i18n(ExportFormats[i].name.toUtf8()) + " (*." + \
                ExportFormats[i].ext + " *." +
-                   ExportFormats[i].ext.toUpper() + ")";
+                   ExportFormats[i].ext.toUpper() + ')';
 
   filename = KFileDialog::getSaveFileName(date + "." + ExportFormats[i].ext, filter, \
0, i18n("Please Choose File"));  if (filename.isEmpty()) // no file selected
@@ -205,7 +205,7 @@
           e + separator +
           f + separator +
           g + separator +
-          h + separator + "\n";
+          h + separator + '\n';
 }
 
 void CSVExport::addEmptyLine() {
--- trunk/KDE/kdenetwork/kppp/modems.cpp #589328:589329
@@ -288,7 +288,7 @@
     n1 = n1 / 1024.0;
 
   QString s = KGlobal::locale()->formatNumber( n1, idx==0 ? 0 : 1 );
-  s += " " + quant[idx];
+  s += ' ' + quant[idx];
   return s;
 }
 
--- trunk/KDE/kdenetwork/kppp/providerdb.cpp #589328:589329
@@ -130,7 +130,7 @@
   QString provider = page3->lb->text(page3->lb->currentItem());
   urlEncode(provider);
   QString prov = "Provider/" + loc;
-  prov += "/" + provider;
+  prov += '/' + provider;
   QString fname = KStandardDirs::locate("appdata", prov);
   kDebug(5002) << "Providerfile=" << fname << endl;
 


[prev in list] [next in list] [prev in thread] [next in thread]