[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kjsembed/tests
From:       Ian Reinhart Geiser <geiseri () sourcextreme ! com>
Date:       2006-09-26 20:31:25
Message-ID: 200609261631.25891.geiseri () sourcextreme ! com
[Download RAW message or body]

All properties are broken currently.  Maksim wants us to do properties in some 
strange manner new with KJS. 

Once I can figure out what he is talking about then I can implement it and 
make it work.

"put is the same. For get, you just basically override getOwnPropertySlot, 
which is supposed to return true or false depending on whether there is a 
property or not, and if there is, set a callback in the PropertySlot thingie.
There is no longer any need for hasProperty (you could also return undefined 
easily, or use the hashtables, but that doesn't matter for this use case)
For example, see e.g. handling of length property here:
http://lxr.kde.org/source/KDE/kdelibs/khtml/ecma/kjs_dom.cpp#645
http://lxr.kde.org/source/KDE/kdelibs/khtml/ecma/kjs_dom.cpp#623"

Is the explanation I got back from him.

Cheers
	-ian reinhart geiser

On Tuesday 26 September 2006 12:52, Richard J. Moore wrote:
> SVN commit 588699 by rich:
>
> Fixed the logic of the args test case. We still need to
> figure out why the applicationName property isn't working
> but that's a different issue.
>
>
>
>  M  +5 -3      args.js
>
>
> --- trunk/KDE/kdelibs/kjsembed/tests/args.js #588698:588699
> @@ -1,3 +1,5 @@
> -println("Application " + Application.applicationName + " arguments ");
> -for( arg in Application.args[0] )
> -	println("Application arg " + arg );
> +// Why is this broken
> +//println("Application " + Application.applicationName + " arguments ");
> +
> +for( arg in Application.args )
> +	println("Application arg " + arg + ' value ' + Application.args[arg] );

[prev in list] [next in list] [prev in thread] [next in thread]