[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdegraphics/kolourpaint/tools (silent)
From:       Clarence Dang <dang () kde ! org>
Date:       2006-09-19 12:48:27
Message-ID: 1158670107.707228.8825.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 586387 by dang:

SVN_SILENT resolve last added TODO


 M  +11 -1     kptoolpen.cpp  


--- branches/KDE/3.5/kdegraphics/kolourpaint/tools/kptoolpen.cpp #586386:586387
@@ -964,7 +964,17 @@
 
     for (int i = 0; i < 2; i++)
     {
-        // TODO: I can't see how this works for transparent?
+        // Note: No matter what, the eraser's brush pixmap is never given
+        //       a mask.
+        //
+        // With a transparent color, since we don't fill anything, the
+        // resize by itself will leave us with garbage pixels.  This
+        // doesn't matter because:
+        //
+        // 1. The hover cursor will ask kpToolWidgetEraserSize for a proper
+        //    cursor pixmap.
+        // 2. We will draw using kpPixmapFX::paintMaskTransparentWithBrush()
+        //    which only cares about the opaqueness.
         m_brushPixmap [i].resize (size, size);
         if (color (i).isOpaque ())
             m_brushPixmap [i].fill (color (i).toQColor ());
[prev in list] [next in list] [prev in thread] [next in thread]