[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdewebdev/quanta
From:       Andras Mantia <amantia () kde ! org>
Date:       2006-09-07 20:42:25
Message-ID: 1157661745.919101.24234.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 581882 by amantia:

Fix crash when creating project through slow links.

 M  +1 -0      ChangeLog  
 M  +11 -4     treeviews/projecttreeview.cpp  


--- branches/KDE/3.5/kdewebdev/quanta/ChangeLog #581881:581882
@@ -25,6 +25,7 @@
         toolbar directory and improve the error message if a toolbar cannot be
         saved [#130236]
       - respect the order of items in the .docrc [#133704]
+      - fix crash when creating project through slow links
 
 Version 3.5.3 (Release date: 23-05-2006; Started 18-03-2005):
  - bugfixes:
--- branches/KDE/3.5/kdewebdev/quanta/treeviews/projecttreeview.cpp #581881:581882
@@ -491,10 +491,17 @@
     }
   }
 
-  if ( m_projectFiles->isEmpty() )
-    m_projectDir->root()->setExpandable( false );
-  else
-    m_projectDir->setOpen( true );
+   if ( m_projectFiles->isEmpty() )
+     m_projectDir->root()->setExpandable( false );
+   /* FIXME:
+    * The below code can cause infinite recursion, possibly over slow links.
+    * setOpen call KFileTreeBranch::openURL, that calls KDirListerCache::listDir,
+    * that calls KDirListerCache::stop, that emit the signal cancelled, that
+    * is connected to KFileTreeBranch::slotCanceled, that emit populateFinished
+    * and we are back in this same function with item being the same and
+    * everything starts over again. */
+//   else
+//     m_projectDir->setOpen( true );
 
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]