[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/3.5/kdelibs/khtml/rendering
From:       André_Wöbbeking <Woebbeking () onlinehome ! de>
Date:       2006-09-02 12:48:23
Message-ID: 200609021448.24303.Woebbeking () onlinehome ! de
[Download RAW message or body]

On Saturday 02 September 2006 14:31, Allan Sandfeld Jensen wrote:
> SVN commit 580037 by carewolf:
>
> Height of body should be based on canvas in quirks mode.
> BUG:95489
>
> Also affects quirksmode.org/css/height/minheightbody.html
>
>
>  M  +8 -1      render_box.cpp
>
>
> --- branches/KDE/3.5/kdelibs/khtml/rendering/render_box.cpp
> #580036:580037 @@ -736,7 +736,7 @@
>          }
>
>          if(!isInline() || isReplaced()) {
> -            _xPos += xPos(),
> +            _xPos += xPos(),
>              _yPos += yPos();
>          }

Why is this ',' and not ';'? I'm not sure about operator precedence here 
but xPos(), _yPos += yPos(); could be _yPos and so probably a bug.


Cheers,
André

[prev in list] [next in list] [prev in thread] [next in thread]