[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/network/konversation/src
From:       Diego Iastrubni <elcuco () kde ! org>
Date:       2006-09-01 20:20:36
Message-ID: 1157142036.543310.813.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 579857 by iastrubni:

This is a work arround for bug 112755. Now conversation support BIDI completely.
The problem was caused by a bug in QTextEdit. See the bug report for a full explain.

I also documented, blah... just gave a link... which explains what are those BIDI \
constants used in the source. 

BUG: 112755
CCMAIL: kde-il@yahoogroups.com, Eike Hein <sho@eikehein.com>


 M  +15 -12    ircview.cpp  


--- trunk/extragear/network/konversation/src/ircview.cpp #579856:579857
@@ -658,7 +658,7 @@
 
     if(basicDirection(message) == QChar::DirR)
     {
-        line = RLO;
+        line = RLE;
         line += LRE;
         line += "<p><font color=\"" + channelColor + "\">" + nickLine + " %1" + PDF \
+ " %3</font></p>\n";  }
@@ -725,7 +725,7 @@
 
     if(basicDirection(message) == QChar::DirR)
     {
-        line = RLO;
+        line = RLE;
         line += LRE;
         line += "<p><font color=\"" + queryColor + "\">" + nickLine + " %1" + PDF + \
" %3</font></p>\n";  }
@@ -759,7 +759,7 @@
 
     if(basicDirection(message) == QChar::DirR)
     {
-        line = RLO;
+        line = RLE;
         line += LRE;
         line += "<p><font color=\"" + actionColor + "\">" + nickLine + " * %1" + PDF \
+ " %3</font></p>\n";  }
@@ -794,7 +794,7 @@
 
     if(basicDirection(message) == QChar::DirR)
     {
-        line = RLO;
+        line = RLE;
         line += LRE;
         line += "<p><font color=\"" + serverColor + "\"" + fixed + \
"><b>[</b>%2<b>]</b> %1" + PDF + " %3</font></p>\n";  }
@@ -836,7 +836,7 @@
 
     if(basicDirection(message) == QChar::DirR)
     {
-        line = RLO;
+        line = RLE;
         line += LRE;
         line += "<p><font color=\"" + commandColor + "\">%2 %1" + PDF + " \
%3</font></p>\n";  }
@@ -1413,13 +1413,16 @@
     return m_popup;
 }
 
-QChar IRCView::LRM = (ushort)0x200e;
-QChar IRCView::RLM = (ushort)0x200f;
-QChar IRCView::LRE = (ushort)0x202a;
-QChar IRCView::RLE = (ushort)0x202b;
-QChar IRCView::RLO = (ushort)0x202e;
-QChar IRCView::LRO = (ushort)0x202d;
-QChar IRCView::PDF = (ushort)0x202c;
+// for more information about these RTFM
+//    http://www.unicode.org/reports/tr9/
+//    http://www.w3.org/TR/unicode-xml/
+QChar IRCView::LRM = (ushort)0x200e; // Right-to-Left Mark
+QChar IRCView::RLM = (ushort)0x200f; // Left-to-Right Mark
+QChar IRCView::LRE = (ushort)0x202a; // Left-to-Right Embedding
+QChar IRCView::RLE = (ushort)0x202b; // Right-to-Left Embedding
+QChar IRCView::RLO = (ushort)0x202e; // Right-to-Left Override
+QChar IRCView::LRO = (ushort)0x202d; // Left-to-Right Override
+QChar IRCView::PDF = (ushort)0x202c; // Previously Defined Format
 
 QChar::Direction IRCView::basicDirection(const QString &string)
 {


[prev in list] [next in list] [prev in thread] [next in thread]