[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdegraphics/kviewshell/shell
From:       Dirk Mueller <mueller () kde ! org>
Date:       2006-08-26 21:38:45
Message-ID: 1156628325.596331.11999.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 577505 by mueller:

- you can't return references to local variables


 M  +3 -6      renderQueue.cpp  
 M  +1 -1      renderQueue.h  


--- trunk/KDE/kdegraphics/kviewshell/shell/renderQueue.cpp #577504:577505
@@ -94,20 +94,17 @@
   emitRenderingFinished(page);
 }
 
-JobId& RenderQueue::requestRenderJob()
+JobId RenderQueue::requestRenderJob()
 {
   QMutexLocker locker(&mutex);
   if (renderQueue.isEmpty())
   {
     // Return a JobId with invalid page number, to indicate the  no rendering requests
     // are in the queue.
-    JobId id = JobId();
-    return id;
+    return JobId();
   }
 
-  JobId page = renderQueue.front();
-
-  return page;
+  return renderQueue.front();
 }
 
 void RenderQueue::emitRenderingFinished(RenderedDocumentPagePixmap* page)
--- trunk/KDE/kdegraphics/kviewshell/shell/renderQueue.h #577504:577505
@@ -62,7 +62,7 @@
   /* The next two functions are only called by the
      renderThread. */
   void addFinishedPage(RenderedDocumentPagePixmap*);
-  JobId& requestRenderJob();
+  JobId requestRenderJob();
 
   /** @brief Wait until a new rendering job is added to the queue.
 
[prev in list] [next in list] [prev in thread] [next in thread]