[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/3.5/kdelibs/khtml/ecma
From:       André_Wöbbeking <Woebbeking () onlinehome ! de>
Date:       2006-08-24 15:46:11
Message-ID: 200608241746.14040.Woebbeking () onlinehome ! de
[Download RAW message or body]

On Thursday 24 August 2006 16:19, David Faure wrote:
> SVN commit 576656 by dfaure:
>
> Calling utf8() twice is expensive, calling length() on a QCString is
> expensive, so better not do either one :) CCBUG: 131242
>
>
>  M  +2 -1      xmlhttprequest.cpp
>
>
> --- branches/KDE/3.5/kdelibs/khtml/ecma/xmlhttprequest.cpp
> #576655:576656 @@ -335,7 +335,8 @@
>      // FIXME: determine post encoding correctly by looking in
> headers // for charset.
>      QByteArray buf;
> -    buf.duplicate(_body.utf8().data(), _body.utf8().length());
> +    QCString str = _body.utf8();
> +    buf.duplicate(str.data(), str.size() - 1);

I love QCString ;-) I hope this will be ported correctly.
[prev in list] [next in list] [prev in thread] [next in thread]