[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/3.5/kdelibs/khtml/html
From:       George Staikos <staikos () kde ! org>
Date:       2006-08-24 15:22:10
Message-ID: 200608241122.10610.staikos () kde ! org
[Download RAW message or body]

On Thursday 24 August 2006 11:32, Frans Englich wrote:
> > --- branches/KDE/3.5/kdelibs/khtml/html/html_inlineimpl.cpp
> > #576667:576668 @@ -175,11 +175,13 @@
> >      switch(attr->id())
> >      {
> >      case ATTR_HREF:
> > +    {
> >          bool hadAnchor = m_hasAnchor;
> >          m_hasAnchor = attr->val() != 0;
> >          getDocument()->incDOMTreeVersion();
> >          if (hadAnchor != m_hasAnchor)
> >              setChanged();
> > +    }
> >          break;
> >      case ATTR_TARGET:
> >          m_hasTarget = attr->val() != 0;
>
> Hm, how did this fix a breakage? Was the scope needed to avoid name
> clashing?
>
> (Any particular reason why the break statement is separated from the other
> code in the case branch?)

  The jump table isn't supposed to cross initialization boundaries.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/
[prev in list] [next in list] [prev in thread] [next in thread]