[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/3.5/kdebase/kcontrol/ebrowsing/plugins/shorturi
From:       Dirk Mueller <mueller () kde ! org>
Date:       2006-08-23 11:23:54
Message-ID: 200608231323.55073.mueller () kde ! org
[Download RAW message or body]

On Wednesday 23 August 2006 12:14, David Faure wrote:

> > +    // stuff like wallpaper.png matches the FQDN_PATTERN but is most
> > +    // likely not a domain
> > +    if (KMimeType::findByPath(cmd) != KMimeType::defaultMimeTypePtr()) {
> > +        return false;
> BTW why is this not just QFile::exists(cmd)?

This is only about filenames without path. for those QFile::exists() has 
probably no useful meaning, and would be wrong anyway. 

> What's the point of determining the mimetype of the file (which could
> possibly be slow, since it might even read its contents if the extension is
> unknown)?

The plan was that it just checks the file name extension, not the file 
contents. It seems that I need an additional true parameter for this, 
committed now. 

Anyway, the point of the commit is that "wallpaper.png" isn't marked to be a 
fully qualified hostname, without doing a DNS lookup. It doesn't make much of 
a difference for the minicli, while it makes a huge difference for Kickoff. 


Dirk

[prev in list] [next in list] [prev in thread] [next in thread]