From kde-commits  Wed Aug 16 06:50:55 2006
From: Ian Reinhart Geiser <geiseri () yahoo ! com>
Date: Wed, 16 Aug 2006 06:50:55 +0000
To: kde-commits
Subject: Re: KDE/kdelibs/kjs
Message-Id: <200608160250.56168.geiseri () yahoo ! com>
X-MARC-Message: https://marc.info/?l=kde-commits&m=115575162913097

On Tuesday 15 August 2006 12:21, you wrote:
> On Tuesday 15 August 2006 11:44, Ian Reinhart Geiser wrote:
> > SVN commit 573287 by geiseri:
> >
> > I am not sure why put is virtual and get is not.  We need get to be
> > virtual so that we can reimplement it in kjsembed. If this is not a cool
> > thing to do then please help me work with properties better in our
> > QObjectBindings.
>
> Please revert. What you should reimplement is getOwnPropertySlot
Should put be virtual then too?  I will revert my last commit, but I would 
like some help using getOwnPropertySlot as I am not sure I understand how it 
works.

Cheers
	-ian reinhart geiser
>
> > --- trunk/KDE/kdelibs/kjs/object.h #573286:573287
> > @@ -227,8 +227,8 @@
> >       *
> >       * @return The specified property, or Undefined
> >       */
> > -    JSValue *get(ExecState *exec, const Identifier &propertyName) const;
> > -    JSValue *get(ExecState *exec, unsigned propertyName) const;
> > +    virtual JSValue *get(ExecState *exec, const Identifier
> > &propertyName) const; +    virtual JSValue *get(ExecState *exec, unsigned
> > propertyName) const;
> >
> >      bool getPropertySlot(ExecState *, const Identifier&, PropertySlot&);
> >      bool getPropertySlot(ExecState *, unsigned, PropertySlot&);