[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/work/unity/WebKit/WebCore/platform/qt
From:       Nikolas Zimmermann <wildfox () kde ! org>
Date:       2006-08-15 21:53:58
Message-ID: 1155678838.996155.10532.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 573371 by wildfox:

When rendering SVGs multiple graphic contexts are used.

CanvasQt constructs a QPainter + GraphicsContext, and for
example RenderSVGText also constructs a GraphicsContext -
but the painter is shared. That leads to the problem that
the painter's end() method is called too early. Fix that.

As soon as the paintEvent() function is left, the QPainter
is destructed anyway - same affect as calling end() before.

Investigation by Rob.
Also enable antialiasing for SVG :-)


 M  +4 -3      GraphicsContextQt.cpp  


--- branches/work/unity/WebKit/WebCore/platform/qt/GraphicsContextQt.cpp #573370:573371
@@ -201,12 +201,13 @@
 {
     painter = p;
     redirect = 0;
-    //painter.setRenderHint(QPainter::Antialiasing);
+
+    // Good looking SVGs please...
+    painter->setRenderHint(QPainter::Antialiasing);
 }
 
 GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate()
 {
-    painter->end();
 }
 
 GraphicsContext::GraphicsContext(PlatformGraphicsContext* context)
@@ -218,7 +219,7 @@
 
 GraphicsContext::~GraphicsContext()
 {
-    while (!m_data->layers.isEmpty()) {
+     while (!m_data->layers.isEmpty()) {
         endTransparencyLayer();
     }
 
[prev in list] [next in list] [prev in thread] [next in thread]