[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kjs
From:       Maks Orlovich <maksim () cs ! cornell ! edu>
Date:       2006-08-15 16:21:56
Message-ID: 200608151221.56660.maksim () cs ! cornell ! edu
[Download RAW message or body]

On Tuesday 15 August 2006 11:44, Ian Reinhart Geiser wrote:
> SVN commit 573287 by geiseri:
>
> I am not sure why put is virtual and get is not.  We need get to be virtual
> so that we can reimplement it in kjsembed. If this is not a cool thing to
> do then please help me work with properties better in our QObjectBindings.


Please revert. What you should reimplement is getOwnPropertySlot


> --- trunk/KDE/kdelibs/kjs/object.h #573286:573287
> @@ -227,8 +227,8 @@
>       *
>       * @return The specified property, or Undefined
>       */
> -    JSValue *get(ExecState *exec, const Identifier &propertyName) const;
> -    JSValue *get(ExecState *exec, unsigned propertyName) const;
> +    virtual JSValue *get(ExecState *exec, const Identifier &propertyName)
> const; +    virtual JSValue *get(ExecState *exec, unsigned propertyName)
> const;
>
>      bool getPropertySlot(ExecState *, const Identifier&, PropertySlot&);
>      bool getPropertySlot(ExecState *, unsigned, PropertySlot&);
[prev in list] [next in list] [prev in thread] [next in thread]