[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdesdk/kbabel/kbabel
From:       Tim Beaulen <tbscope () gmail ! com>
Date:       2006-08-13 10:29:16
Message-ID: 1155464956.911555.25146.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 572587 by beaulen:

- Fix crash while editing entries without tags.
- Fix warnings about painting outside the paintevent



 M  +9 -0      kbabelview2.cpp  
 M  +1 -1      main.cpp  
 M  +1 -2      mymultilineedit.cpp  


--- trunk/KDE/kdesdk/kbabel/kbabel/kbabelview2.cpp #572586:572587
@@ -266,6 +266,15 @@
 	return;
     }
 
+    // WARNING: Somehow _tagExtractor->countMatches doesn't return 0 when there are \
no tags. +    // I haven't figured it out why this is yet. But this check is good \
anyway. Without it, entries without tags +    // will make KBabel crash (because \
below the code is searching in the tagslist but it's empty so there will be  +    // \
an assert for QList index). (TBScope) +    if( _tags.isEmpty() ) {
+        msgidLabel->selectTag(0,0);
+        return;
+    }
+
     // count number of eofs in tag
     uint diff=0;
     // FIXME: what about plural forms
--- trunk/KDE/kdesdk/kbabel/kbabel/main.cpp #572586:572587
@@ -98,7 +98,7 @@
 
 KBabelApp::~KBabelApp()
 {
-    delete kbInterface;
+    //delete kbInterface;
 }
 
 int KBabelApp::newInstance()
--- trunk/KDE/kdesdk/kbabel/kbabel/mymultilineedit.cpp #572586:572587
@@ -1408,8 +1408,7 @@
     // FIXME as soon as it's possible to ask real margins from QTextEdit:
     const int left_margin = 4;
     // const int top_margin = 4;
-    
-    Q3Painter painter( viewport());
+
     const QRect& linerect = paragraphRect(para);
     return QRect(
         contentsToViewport( QPoint(


[prev in list] [next in list] [prev in thread] [next in thread]