[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/work/icecream-make-it-cool/services
From:       Michael Matz <matz () kde ! org>
Date:       2006-08-08 13:30:29
Message-ID: Pine.LNX.4.64.0608081523280.25141 () wotan ! suse ! de
[Download RAW message or body]

On Mon, 7 Aug 2006, Dirk Mueller wrote:

> SVN commit 570776 by mueller:
> 
> should this be enough to fix at_eof() semantics?

Yes.  Having a cached eof is not a real eof only if state is HAS_MSG.  
Being in NEED_PROTO (unlikely) or NEED_LEN means that this is a real eof.

> --- branches/work/icecream-make-it-cool/services/comm.h #570775:570776
> @@ -149,7 +149,7 @@
>    bool write_a_bit (void) {
>      return need_write () ? flush_writebuf (false) : true;
>    }
> -  bool at_eof (void) const { return eof; }
> +  bool at_eof (void) const { return instate != HAS_MSG && eof; }
>    bool is_text_based(void) const { return text_based; }
>  
>    void readuint32 (uint32_t &buf);


Ciao,
Michael.
[prev in list] [next in list] [prev in thread] [next in thread]