[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/multimedia/amarok/src
From:       Seb Ruiz <me () sebruiz ! net>
Date:       2006-08-08 13:00:13
Message-ID: 1155042013.312879.7395.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 571054 by seb:

Due to a bug which is very difficult to solve, cancelling a drag of an album cover \
within the context browser would start another drag due to deficiencies in khtml. \
Disabling the custom drag pixmap now...


 M  +2 -5      htmlview.cpp  
 M  +1 -1      htmlview.h  


--- trunk/extragear/multimedia/amarok/src/htmlview.cpp #571053:571054
@@ -256,7 +256,7 @@
         Playlist::instance()->insertMedia( url, Playlist::DirectPlay | \
Playlist::Unique );  }
 
-#include "debug.h"
+#if 0
 #include "qpixmap.h"
 #include "qdragobject.h"
 #include "kurldrag.h"
@@ -285,15 +285,12 @@
         drag->setPixmap( pix, QPoint( CollectionDB::DRAGPIXMAP_OFFSET_X, \
CollectionDB::DRAGPIXMAP_OFFSET_Y ) );  
         drag->dragCopy();
-
-        /// khtmlPart wasn't very well designed. The only way to tell it that the \
                drag finished, is to set a private
-        /// member, KHTMLPart::d->m_bMousePressed = false, which is of course \
                impossible, because it is private.
-        /// TODO: GET AROUND IT!!!
         return;
     }
 
     // let KHTMLPart terminate
     KHTMLPart::khtmlMouseMoveEvent( event );
 }
+#endif
 
 #include "htmlview.moc"
--- trunk/extragear/multimedia/amarok/src/htmlview.h #571053:571054
@@ -27,7 +27,7 @@
 
     private:
         // for overloading the drag and drop image
-        void   khtmlMouseMoveEvent( khtml::MouseMoveEvent *event );
+//         void   khtmlMouseMoveEvent( khtml::MouseMoveEvent *event );
 
         static KTempFile *m_bgGradientImage;
         static KTempFile *m_headerGradientImage;


[prev in list] [next in list] [prev in thread] [next in thread]