[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/work/unity/WebKit/WebCore/platform/qt (silent)
From:       Nikolas Zimmermann <wildfox () kde ! org>
Date:       2006-08-04 15:54:50
Message-ID: 1154706890.709602.12695.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 569718 by wildfox:

SVN_SILENT: cleanup the beast a bit...


 M  +10 -163   FrameQt.cpp  


--- branches/work/unity/WebKit/WebCore/platform/qt/FrameQt.cpp #569717:569718
@@ -200,11 +200,13 @@
 
 bool FrameQt::runJavaScriptConfirm(String const& message)
 {
+    notImplemented();
     return true;
 }
 
 bool FrameQt::locationbarVisible()
 {
+    notImplemented();
     return true;
 }
 
@@ -219,7 +221,6 @@
     return 0;
 }
 
-
 bool FrameQt::passWheelEventToChildWidget(Node*)
 {
     notImplemented();
@@ -237,6 +238,7 @@
 ObjectContentType FrameQt::objectContentType(const KURL&, const String& mimeType)
 {
     notImplemented();
+    return ObjectContentType();
 }
 
 Plugin* FrameQt::createPlugin(Element*, const KURL&, const Vector<String>&, const \
Vector<String>&, const String&) @@ -360,7 +362,6 @@
     return false;
 }
 
-
 KJS::Bindings::Instance* FrameQt::getEmbedInstanceForWidget(Widget*)
 {
     notImplemented();
@@ -453,26 +454,30 @@
 bool FrameQt::canGoBackOrForward(int distance) const
 {
     notImplemented();
+    return false;
 }
 
 void FrameQt::handledOnloadEvents()
 {
-    notImplemented();
+    // no-op
 }
 
 bool FrameQt::canPaste() const
 {
     notImplemented();
+    return false;
 }
 
 bool FrameQt::canRedo() const
 {
     notImplemented();
+    return false;
 }
 
 bool FrameQt::canUndo() const
 {
     notImplemented();
+    return false;
 }
 
 void FrameQt::print()
@@ -480,144 +485,12 @@
     notImplemented();
 }
 
-
 bool FrameQt::shouldInterruptJavaScript()
 {
     notImplemented();
+    return false;
 }
 
-
-#if 0
-void FrameQt::handleGdkEvent(GdkEvent* event)
-{
-    switch (event->type) {
-        case GDK_EXPOSE: {
-            GdkRectangle clip;
-            gdk_region_get_clipbox(event->expose.region, &clip);
-            gdk_window_begin_paint_region (event->any.window, event->expose.region);
-            cairo_t* cr = gdk_cairo_create (event->any.window);
-            GraphicsContext* ctx = new GraphicsContext(cr);
-            paint(ctx, IntRect(clip.x, clip.y, clip.width, clip.height));
-            delete ctx;
-            gdk_window_end_paint (event->any.window);
-            break;
-        }
-        case GDK_SCROLL: {
-            PlatformWheelEvent wheelEvent(event);
-            view()->handleWheelEvent(wheelEvent);
-            if (wheelEvent.isAccepted()) {
-                return;
-            }
-            RenderObject::NodeInfo nodeInfo(true, true);
-            renderer()->layer()->hitTest(nodeInfo, wheelEvent.pos());
-            Node* node = nodeInfo.innerNode();
-            if (!node)
-                return;
-            //Default to scrolling the page
-            //not sure why its null
-            //broke anyway when its not null
-            doScroll(renderer(), wheelEvent.isHorizontal(), wheelEvent.delta());
-            break;
-        }
-        case GDK_DRAG_ENTER:
-        case GDK_DRAG_LEAVE:
-        case GDK_DRAG_MOTION:
-        case GDK_DRAG_STATUS:
-        case GDK_DROP_START:
-        case GDK_DROP_FINISHED: {
-            //bool updateDragAndDrop(const PlatformMouseEvent&, Clipboard*);
-            //void cancelDragAndDrop(const PlatformMouseEvent&, Clipboard*);
-            //bool performDragAndDrop(const PlatformMouseEvent&, Clipboard*);
-            break;
-        }
-        case GDK_MOTION_NOTIFY:
-            view()->handleMouseMoveEvent(event);
-            break;
-        case GDK_BUTTON_PRESS:
-        case GDK_2BUTTON_PRESS:
-        case GDK_3BUTTON_PRESS:
-            view()->handleMousePressEvent(event);
-            break;
-        case GDK_BUTTON_RELEASE:
-            view()->handleMouseReleaseEvent(event);
-            break;
-        case GDK_KEY_PRESS:
-        case GDK_KEY_RELEASE: {
-            PlatformKeyboardEvent kevent(event);
-            bool handled = false;
-            if (!kevent.isKeyUp()) {
-                Node* start = selection().start().node();
-                if (start && start->isContentEditable()) {
-                    switch(kevent.WindowsKeyCode()) {
-                        case VK_BACK:
-                            TypingCommand::deleteKeyPressed(document());
-                            break;
-                        case VK_DELETE:
-                            TypingCommand::forwardDeleteKeyPressed(document());
-                            break;
-                        case VK_LEFT:
-                            selection().modify(SelectionController::MOVE, \
                SelectionController::LEFT, CharacterGranularity);
-                            break;
-                        case VK_RIGHT:
-                            selection().modify(SelectionController::MOVE, \
                SelectionController::RIGHT, CharacterGranularity);
-                            break;
-                        case VK_UP:
-                            selection().modify(SelectionController::MOVE, \
                SelectionController::BACKWARD, ParagraphGranularity);
-                            break;
-                        case VK_DOWN:
-                            selection().modify(SelectionController::MOVE, \
                SelectionController::FORWARD, ParagraphGranularity);
-                            break;
-                        default:
-                            TypingCommand::insertText(document(), kevent.text(), \
                false);
-
-                    }
-                    handled = true;
-                }
-                if (!handled) {
-                    switch (kevent.WindowsKeyCode()) {
-                        case VK_LEFT:
-                            doScroll(renderer(), true, -120);
-                            break;
-                        case VK_RIGHT:
-                            doScroll(renderer(), true, 120);
-                            break;
-                        case VK_UP:
-                            doScroll(renderer(), false, -120);
-                            break;
-                        case VK_PRIOR:
-                            //return SB_PAGEUP;
-                            break;
-                        case VK_NEXT:
-                            //return SB_PAGEDOWN;
-                            break;
-                        case VK_DOWN:
-                            doScroll(renderer(), false, 120);
-                            break;
-                        case VK_HOME:
-                            renderer()->layer()->scrollToOffset(0, 0, true, true);
-                            doScroll(renderer(), false, 120);
-                            break;
-                        case VK_END:
-                            renderer()->layer()->scrollToOffset(0,
-                                                                \
                renderer()->height(), true, true);
-                            break;
-                        case VK_SPACE:
-                            if (kevent.shiftKey())
-                                doScroll(renderer(), false, -120);
-                            else
-                                doScroll(renderer(), false, 120);
-                            break;
-                    }
-
-                }
-            }
-        }
-        default:
-            break;
-    }
-}
-#endif
-
 void FrameQt::receivedData(TransferJob* job, const char* data, int length)
 {
     write(data, length);
@@ -630,35 +503,9 @@
 
 void FrameQt::setFrameGeometry(const IntRect &r)
 {
-    QRect s(r.x(), r.y(),r.width(),r.height());
-    setFrameGeometry(s);
+    setFrameGeometry((QRect) r);
 }
 
-#if 0
-bool FrameQt::passWheelEventToChildWidget(Node* node)
-{
-    if (!node)
-        return false;
-    RenderObject* renderer = node->renderer();
-    if (!renderer || !renderer->isWidget())
-        return false;
-    Widget* widget = static_cast<RenderWidget*>(renderer)->widget();
-    if (!widget)
-
-return false;
-    return true;
 }
 
-bool FrameQt::passSubframeEventToSubframe(MouseEventWithHitTestResults& mev, Frame*)
-{
-    if (mev.targetNode() == 0)
-        return true;
-    return false;
-}
-#endif
-
-
-}
-
-
 // vim: ts=4 sw=4 et


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic