From kde-commits Mon Jul 31 23:33:38 2006 From: Allen Winter Date: Mon, 31 Jul 2006 23:33:38 +0000 To: kde-commits Subject: KDE/kdepimlibs/kabc Message-Id: <1154388818.778193.1166.nullmailer () svn ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=115438884428420 SVN commit 568386 by winterz: passbyvalue fixes. M +7 -8 kab/qconfigDB.cc M +2 -1 ldifconverter.cpp --- trunk/KDE/kdepimlibs/kabc/kab/qconfigDB.cc #568385:568386 @@ -37,16 +37,15 @@ #define KAB_KDEBUG_AREA 800 -static bool isComment(QByteArray line) +static bool isComment(const QByteArray &line) { // ############################################################################ - line=line.trimmed(); - if (line.isEmpty()) - { - return false; // line is empty but not a comment - } else { - return(line[0]=='#'); - } + QByteArray tline = line.trimmed(); + if (tline.isEmpty()) { + return false; // line is empty but not a comment + } else { + return(tline[0]=='#'); + } // ############################################################################ } --- trunk/KDE/kdepimlibs/kabc/ldifconverter.cpp #568385:568386 @@ -62,7 +62,8 @@ -static void ldif_out( QTextStream &t, QString formatStr, QString value ) +static void ldif_out( QTextStream &t, const QString &formatStr, + const QString &value ) { if ( value.isEmpty() ) return;