[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepimlibs/kldap
From:       Allen Winter <winter () kde ! org>
Date:       2006-07-31 20:55:16
Message-ID: 200607311655.16832.winter () kde ! org
[Download RAW message or body]

On Monday 31 July 2006 16:05, Szombathelyi György wrote:
> SVN commit 568324 by gyurco:
> 
> Installed headers now can be used.
> 
This patch brings up a question I've been meaning to ask the universe...

Shouldn't files that are included from within the same subdir (or module,
for that matter) be in double-quotes instead of angle-brackets??

i.e.
#include "kldap.h"
instead of
#include <klap.h>


> 
>  M  +3 -3      ldapconfigwidget.h  
>  M  +3 -3      ldapconnection.h  
>  M  +1 -1      ldapcontrol.h  
>  M  +1 -1      ldapobject.h  
>  M  +6 -6      ldapoperation.h  
>  M  +2 -2      ldapserver.h  
>  M  +1 -1      ldapurl.h  
>  M  +1 -1      ldif.h  
> 
> 
> --- trunk/KDE/kdepimlibs/kldap/ldapconfigwidget.h #568323:568324
> @@ -26,9 +26,9 @@
>  
>  #include <kio/job.h>
>  
> -#include <ldif.h>
> -#include <ldapurl.h>
> -#include <ldapserver.h>
> +#include <kldap/ldif.h>
> +#include <kldap/ldapurl.h>
> +#include <kldap/ldapserver.h>
>  
>  #include <kldap.h>
>  
> --- trunk/KDE/kdepimlibs/kldap/ldapconnection.h #568323:568324
> @@ -23,9 +23,9 @@
>  
>  #include <QString>
>  
> -#include <ldapurl.h>
> -#include <ldapserver.h>
> -#include <kldap.h>
> +#include <kldap/ldapurl.h>
> +#include <kldap/ldapserver.h>
> +#include <kldap/kldap.h>
>  
>  namespace KLDAP {
>  
> --- trunk/KDE/kdepimlibs/kldap/ldapcontrol.h #568323:568324
> @@ -24,7 +24,7 @@
>  #include <QString>
>  #include <QList>
>  
> -#include <kldap.h>
> +#include <kldap/kldap.h>
>  
>  namespace KLDAP {
>  
> --- trunk/KDE/kdepimlibs/kldap/ldapobject.h #568323:568324
> @@ -25,7 +25,7 @@
>  #include <QList>
>  #include <QMap>
>  
> -#include <kldap.h>
> +#include <kldap/kldap.h>
>  
>  namespace KLDAP {
>  
> --- trunk/KDE/kdepimlibs/kldap/ldapoperation.h #568323:568324
> @@ -25,13 +25,13 @@
>  #include <QList>
>  #include <QByteArray>
>  
> -#include <ldapurl.h>
> -#include <ldapobject.h>
> -#include <ldapcontrol.h>
> -#include <ldapserver.h>
> -#include <ldapconnection.h>
> +#include <kldap/ldapurl.h>
> +#include <kldap/ldapobject.h>
> +#include <kldap/ldapcontrol.h>
> +#include <kldap/ldapserver.h>
> +#include <kldap/ldapconnection.h>
>  
> -#include <kldap.h>
> +#include <kldap/kldap.h>
>  
>  namespace KLDAP {
>  
> --- trunk/KDE/kdepimlibs/kldap/ldapserver.h #568323:568324
> @@ -23,8 +23,8 @@
>  
>  #include <QString>
>  
> -#include <ldapurl.h>
> -#include <kldap.h>
> +#include <kldap/ldapurl.h>
> +#include <kldap/kldap.h>
>  
>  namespace KLDAP {
>  
> --- trunk/KDE/kdepimlibs/kldap/ldapurl.h #568323:568324
> @@ -25,7 +25,7 @@
>  #include <QStringList>
>  
>  #include <kurl.h>
> -#include <kldap.h>
> +#include <kldap/kldap.h>
>  
>  namespace KLDAP {
>  
> --- trunk/KDE/kdepimlibs/kldap/ldif.h #568323:568324
> @@ -24,7 +24,7 @@
>  #include <QString>
>  #include <QByteArray>
>  
> -#include <kldap.h>
> +#include <kldap/kldap.h>
>  
>  namespace KLDAP {
>  
> 
> 
> 

-- 
KDE: Same Thing We Do Everyday... Try to Conquer the World


[prev in list] [next in list] [prev in thread] [next in thread]