[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    playground/pim/kmobiletools/kmobiletools
From:       Diego Pettenò <flameeyes () gentoo ! org>
Date:       2006-07-31 20:27:02
Message-ID: 1154377622.755820.13023.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 568329 by dgp:

Make -Wparentheses happy, by adding parentheses where assignments are used as truth \
conditions.

 M  +1 -1      deviceparts/statusbar.cpp  
 M  +3 -3      libkmobiletools/engineloader.cpp  
 M  +2 -2      libkmobiletools/kmobiletoolshelper.cpp  
 M  +1 -1      libkmobiletools/pickphonenumberdialog.cpp  
 M  +1 -1      libkmobiletools/smslist.cpp  
 M  +1 -1      mainpart/newdevicewizard.cpp  


--- trunk/playground/pim/kmobiletools/kmobiletools/deviceparts/statusbar.cpp \
#568328:568329 @@ -178,7 +178,7 @@
     QPtrListIterator<StatusBarJob> it(jobs);
     StatusBarJob *curjob=0;
     int totalprogress=0;
-    while (curjob=it.current() )
+    while ( (curjob=it.current()) )
     {
         totalprogress+=curjob->progress();
         ++it;
--- trunk/playground/pim/kmobiletools/kmobiletools/libkmobiletools/engineloader.cpp \
#568328:568329 @@ -72,7 +72,7 @@
     DeviceInfos *item=0;
     QPtrListIterator<DeviceInfos> it(*this);
     int i=0;
-    while( item=it.current() )
+    while( (item=it.current()) )
     {
         ++it;
         kdDebug() << "DevicesInfoList::dump(); item " << i << ": imei=" << \
item->imei() << "; " << item->rawManufacturer() << " " << item->model() << endl; @@ \
-138,7 +138,7 @@  {
     QPtrListIterator<DeviceInfos> it(*this);
     DeviceInfos *foundItem;
-    while(foundItem=it.current() )
+    while( (foundItem=it.current()) )
     {
         ++it;
         if(foundItem->foundPath() == path ) return foundItem;
@@ -150,7 +150,7 @@
 {
     QPtrListIterator<DeviceInfos> it(*this);
     DeviceInfos *foundItem;
-    while(foundItem=it.current() )
+    while( (foundItem=it.current()) )
     {
         ++it;
         if(foundItem->imei() == imei ) return foundItem;
--- trunk/playground/pim/kmobiletools/kmobiletools/libkmobiletools/kmobiletoolshelper.cpp \
#568328:568329 @@ -74,7 +74,7 @@
     QPtrListIterator<kmobiletoolsEngine> it_engine ( *EnginesList::instance() );
     kmobiletoolsEngine *engine;
     QString retval;
-    while(engine=it_engine.current() )
+    while( (engine=it_engine.current()) )
     {
         ++it_engine;
         retval=translateNumber(s_number, engine->addresseeList() );
@@ -93,7 +93,7 @@
     KABC::Addressee *addressee;
     QValueList<KABC::PhoneNumber> numberslist;
     QValueListIterator<KABC::PhoneNumber> it_phonenumber;
-    while(addressee=it_addressee.current() )
+    while( (addressee=it_addressee.current()) )
     {
         ++it_addressee;
         numberslist=addressee->phoneNumbers();
--- trunk/playground/pim/kmobiletools/kmobiletools/libkmobiletools/pickphonenumberdialog.cpp \
#568328:568329 @@ -118,7 +118,7 @@
     QPtrListIterator<KABC::Addressee> it(*addresseeList);
     KListViewItem *newItem;
     KABC::PhoneNumber::List numbersList;
-    while (curItem=it.current() )
+    while ( (curItem=it.current()) )
     {
         numbersList=curItem->phoneNumbers();
         ++it;
--- trunk/playground/pim/kmobiletools/kmobiletools/libkmobiletools/smslist.cpp \
#568328:568329 @@ -201,7 +201,7 @@
             + QDir::separator() + '.' + \
KMobileTools::DevicesConfig::prefs(s_enginename)->devicename() + ".directory";  \
QPtrListIterator<SMS> it(*this);  SMS *sms;
-    while( sms=it.current() )
+    while( (sms=it.current()) )
     {
         ++it;
         sms->exportMD(dir);
--- trunk/playground/pim/kmobiletools/kmobiletools/mainpart/newdevicewizard.cpp \
#568328:568329 @@ -210,7 +210,7 @@
     mobilesList->clear();
     if(newDevicesList->count() ) probed=true;
     QPtrListIterator<DeviceInfos> it(*newDevicesList);
-    while (p_selectedDevice=it.current())
+    while ( (p_selectedDevice=it.current()) )
     {
         ++it;
         new KListViewItem(mobilesList,


[prev in list] [next in list] [prev in thread] [next in thread]