[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/koffice/1.6/koffice/lib/kotext
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2006-07-30 16:14:58
Message-ID: 200607301814.59040.hausmann () kde ! org
[Download RAW message or body]


On Saturday 29. July 2006 09:51, Thomas Zander wrote:
> On Friday 28 July 2006 18:01, David Faure wrote:
> > On Friday 28 July 2006 17:06, Thomas Zander wrote:
> > > SVN commit 567378 by zander:
> > >
> > > Hardcode the characters that the spec states are whitespace
> > >
> > >
> > >  M  +2 -1      KoTextParag.cpp
> > >
> > >
> > > --- branches/koffice/1.6/koffice/lib/kotext/KoTextParag.cpp
> > > #567377:567378 @@ -2705,7 +2705,8 @@
> > >      {
> > >          QCharRef ch = text[r];
> > >
> > > -        if ( ch.isSpace() )
> > > +        // check for space, tab, line feed, carriage return
> > > +        if ( ch == 0x0020 || ch == 0x0009 ||ch == 0x000A ||  ch ==
> > > 0x000D)
> >
> > The koffice-devel patch was a bit more readable imho ;)
>
> But is it guarenteed to be the same?
> I'm the first to admit my C++ knowledge is not 100%  but I recalled
> that '\n' mapped to different sequences on different compilers or
> platforms.

That's certainly not the case for the compilers/platforms KDE supports.

Simon

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]