[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/runtime/kioslave/sftp
From:       André_Wöbbeking <Woebbeking () onlinehome ! de>
Date:       2006-07-19 15:08:28
Message-ID: 200607191708.28899.Woebbeking () onlinehome ! de
[Download RAW message or body]

On Wednesday 19 July 2006 14:32, Stephan Kulow wrote:
> Am Mittwoch, 19. Juli 2006 13:39 schrieb Laurent Montel:
> > On Wednesday 19 July 2006 12:58, Stephan Kulow wrote:
> > > Am Mittwoch, 19. Juli 2006 12:15 schrieb Laurent Montel:
> > > > SVN commit 564120 by mlaurent:
> > > >
> > > > Deprecated--
> > > >
> > > >
> > > >  M  +1 -1      kio_sftp.cpp
> > > >
> > > >
> > > > --- trunk/KDE/kdebase/runtime/kioslave/sftp/kio_sftp.cpp
> > > > #564119:564120 @@ -449,7 +449,7 @@
> > > >          return;
> > > >
> > > >      // Get resume offset
> > > > -    quint64 offset =
> > > > config()->readUnsignedLongNumEntry("resume"); +    quint64
> > > > offset = config()->readEntry("resume",0);

this should be readUnsignedNum64Entry in KDE 3.5.

> > > Will this really return a quint64 or will it return an int casted
> > > to one?
> >
> > We have:
> >   KDE_DEPRECATED long readLongNumEntry( const QString& pKey, long
> > nDefault = 0 ) const
> >     { return readEntry(pKey, static_cast<int>(nDefault)); }

shouldn't this be readEntry(pKey, static_cast<long>(nDefault))?

> >
> > So for me it will return casted int.
>
> Then we just dropped large file system support for sftp ;(

readEntry("resume",static_cast<quint64>(0))


Cheers,
Andrà ©
[Attachment #3 (text/html)]

<html><head><meta name="qrichtext" content="1" /></head><body style="font-size:15pt;font-family:Arial">
<p>On Wednesday 19 July 2006 14:32, Stephan Kulow wrote:</p>
<p>&gt; Am Mittwoch, 19. Juli 2006 13:39 schrieb Laurent Montel:</p>
<p>&gt; &gt; On Wednesday 19 July 2006 12:58, Stephan Kulow wrote:</p>
<p>&gt; &gt; &gt; Am Mittwoch, 19. Juli 2006 12:15 schrieb Laurent Montel:</p>
<p>&gt; &gt; &gt; &gt; SVN commit 564120 by mlaurent:</p>
<p>&gt; &gt; &gt; &gt;</p>
<p>&gt; &gt; &gt; &gt; Deprecated--</p>
<p>&gt; &gt; &gt; &gt;</p>
<p>&gt; &gt; &gt; &gt;</p>
<p>&gt; &gt; &gt; &gt;  M  +1 -1      kio_sftp.cpp</p>
<p>&gt; &gt; &gt; &gt;</p>
<p>&gt; &gt; &gt; &gt;</p>
<p>&gt; &gt; &gt; &gt; --- trunk/KDE/kdebase/runtime/kioslave/sftp/kio_sftp.cpp</p>
<p>&gt; &gt; &gt; &gt; #564119:564120 @@ -449,7 +449,7 @@</p>
<p>&gt; &gt; &gt; &gt;          return;</p>
<p>&gt; &gt; &gt; &gt;</p>
<p>&gt; &gt; &gt; &gt;      // Get resume offset</p>
<p>&gt; &gt; &gt; &gt; -    quint64 offset =</p>
<p>&gt; &gt; &gt; &gt; config()-&gt;readUnsignedLongNumEntry(&quot;resume&quot;); +    quint64</p>
<p>&gt; &gt; &gt; &gt; offset = config()-&gt;readEntry(&quot;resume&quot;,0);</p>
<p></p>
<p>this should be readUnsignedNum64Entry in KDE 3.5.</p>
<p></p>
<p>&gt; &gt; &gt; Will this really return a quint64 or will it return an int casted</p>
<p>&gt; &gt; &gt; to one?</p>
<p>&gt; &gt;</p>
<p>&gt; &gt; We have:</p>
<p>&gt; &gt;   KDE_DEPRECATED long readLongNumEntry( const QString&amp; pKey, long</p>
<p>&gt; &gt; nDefault = 0 ) const</p>
<p>&gt; &gt;     { return readEntry(pKey, static_cast&lt;int&gt;(nDefault)); }</p>
<p></p>
<p>shouldn't this be readEntry(pKey, static_cast&lt;long&gt;(nDefault))?</p>
<p></p>
<p>&gt; &gt;</p>
<p>&gt; &gt; So for me it will return casted int.</p>
<p>&gt;</p>
<p>&gt; Then we just dropped large file system support for sftp ;(</p>
<p></p>
<p>readEntry(&quot;resume&quot;,static_cast&lt;quint64&gt;(0))</p>
<p></p>
<p></p>
<p>Cheers,</p>
<p>André</p>
</body></html>

[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic