From kde-commits  Fri Jul 14 14:24:38 2006
From: Maks Orlovich <maksim () cs ! cornell ! edu>
Date: Fri, 14 Jul 2006 14:24:38 +0000
To: kde-commits
Subject: Re: branches/KDE/3.5/kdelibs/khtml/dom
Message-Id: <200607141024.38319.maksim () cs ! cornell ! edu>
X-MARC-Message: https://marc.info/?l=kde-commits&m=115288717728972

On Friday 14 July 2006 04:49, Dirk Mueller wrote:
> SVN commit 562182 by mueller:
>
> now that people blog about how easy it is to crash,
> lets just fix it

Dirk, why is this being done here and not in impl anyway?

>
>
>  M  +1 -1      dom_node.cpp
>
>
> --- branches/KDE/3.5/kdelibs/khtml/dom/dom_node.cpp #562181:562182
> @@ -273,7 +273,7 @@
>      NodeImpl *r = impl->replaceChild( newChild.impl, oldChild.impl,
> exceptioncode ); if (exceptioncode)
>  	throw DOMException(exceptioncode);
> -    if (!newChild.impl->closed()) newChild.impl->close();
> +    if (newChild.impl && !newChild.impl->closed()) newChild.impl->close();
>      return r;
>  }