[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kparts
From:       André_Wöbbeking <Woebbeking () onlinehome ! de>
Date:       2006-06-27 18:11:27
Message-ID: 200606272011.27373.Woebbeking () onlinehome ! de
[Download RAW message or body]

On Tuesday 27 June 2006 19:14, Olivier Goffart wrote:
> SVN commit 555514 by ogoffart:
>
> use a true virtual function, and not the virtual_hook
>
>  M  +1 -4      factory.cpp
>  M  +1 -11     factory.h
>  M  +5 -10     genericfactory.h
>
>
> --- trunk/KDE/kdelibs/kparts/factory.cpp #555513:555514
> @@ -49,10 +49,7 @@
>
>  const KInstance *Factory::partInstance()
>  {
> -    QueryInstanceParams params;
> -    params.instance = 0;
> -    virtual_hook( VIRTUAL_QUERY_INSTANCE_PARAMS, &params );
> -    return params.instance;
> +	return 0;
>  }

while you're at it, shouldn't the method be const?
[prev in list] [next in list] [prev in thread] [next in thread]