[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdelibs/khtml/xml
From:       Andreas Kling <kling () impul ! se>
Date:       2006-06-09 17:34:51
Message-ID: 1149874491.035968.22578.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 549744 by kling:

toLengthArray() should return null for comma-less strings.
RenderFrameSet::layout() checks for this, but stuff like <frameset cols=""> makes KHTML crash.

BUG: 128792


 M  +5 -0      dom_stringimpl.cpp  


--- branches/KDE/3.5/kdelibs/khtml/xml/dom_stringimpl.cpp #549743:549744
@@ -308,6 +308,11 @@
     str = str.simplifyWhiteSpace();
 
     len = str.contains(',') + 1;
+
+    // If we have no commas, we have no array.
+    if( len == 1 )
+        return 0L;
+
     khtml::Length* r = new khtml::Length[len];
 
     int i = 0;
[prev in list] [next in list] [prev in thread] [next in thread]