[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdeadmin/knetworkconf/knetworkconf
From:       Jonathan Riddell <jr () jriddell ! org>
Date:       2006-05-30 0:26:57
Message-ID: 1148948817.119909.11440.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 546419 by jriddell:

fix crash in netmask/broadcast
    calculation in case of empty/uninitialized fields
https://launchpad.net/distros/ubuntu/+source/kdeadmin/+bug/30775
Patch by Luka Renko 


 M  +4 -0      kaddressvalidator.cpp  


--- branches/KDE/3.5/kdeadmin/knetworkconf/knetworkconf/kaddressvalidator.cpp #546418:546419
@@ -188,6 +188,8 @@
   struct in_addr _addr, _netmask, _network;
   int prefix = 0;
   QString s;  
+  if (addr.isNull() || netmask.isNull())
+    return NULL; //bad address
   if (!inet_pton(AF_INET,addr.latin1(),&_addr))
     return NULL; //bad address
   else
@@ -214,6 +216,8 @@
   struct in_addr _addr, _netmask, _network;
   int prefix = 0;
   QString s;
+  if (addr.isNull() || netmask.isNull())
+    return NULL; //bad address
   if (!inet_pton(AF_INET,addr.latin1(),&_addr))
     return NULL; //bad address
   else
[prev in list] [next in list] [prev in thread] [next in thread]