[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdegraphics/kpovmodeler
From:       Dirk Mueller <mueller () kde ! org>
Date:       2006-05-27 12:00:25
Message-ID: 1148731225.322200.2553.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 545366 by mueller:

assume obj can't be null otherwise all of the rest
of the method crashes (various coverity reports)


 M  +9 -12     pmtreeview.cpp  


--- branches/KDE/3.5/kdegraphics/kpovmodeler/pmtreeview.cpp #545365:545366
@@ -180,19 +180,16 @@
       {
          clearSelection( );
 
-         if( obj )
-         {
-            if( !pTreeItem )
-               pTreeItem = findObject( obj );
+         if( !pTreeItem )
+             pTreeItem = findObject( obj );
 
-            if( pTreeItem )
-            {
-               PMTreeViewItem* p;
-               for( p = pTreeItem->parent( ); p; p = p->parent( ) )
-                  p->setOpen( true );
-               pTreeItem->setSelected( true );
-               setCurrentItem( pTreeItem );
-            }
+         if( pTreeItem )
+         {
+             PMTreeViewItem* p;
+             for( p = pTreeItem->parent( ); p; p = p->parent( ) )
+                 p->setOpen( true );
+             pTreeItem->setSelected( true );
+             setCurrentItem( pTreeItem );
          }
       }
       if( mode & PMCDeselected )
[prev in list] [next in list] [prev in thread] [next in thread]