[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdewebdev/quanta/parts/kafka
From:       Andras Mantia <amantia () kde ! org>
Date:       2006-05-19 10:04:44
Message-ID: 1148033084.460222.30972.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 542425 by amantia:

Avoid some more crashes in VPL. The real crash-avoider fix is in KHTML.

 M  +13 -2     kafkacommon.cpp  


--- branches/KDE/3.5/kdewebdev/quanta/parts/kafka/kafkacommon.cpp #542424:542425
@@ -3689,14 +3689,25 @@
             return false;
         parent = rootNode;
     }
+    //Andras: avoid exceptions    
+    if (!nextSibling.isNull() && nextSibling.parentNode() != parent)
+    {
+      kdDebug(25001)<< "kafkaCommon::insertDomNode() - invalid nextSibling!" << endl;
+      return false;
+    }
+    if (node.ownerDocument() != parent.ownerDocument())
+    {
+      kdDebug(25001)<< "kafkaCommon::insertDomNode() - ownerDocument is different!" << endl;
+      return false;
+    }
 
     try
     {
         parent.insertBefore(node, nextSibling);
     }
-    catch(DOM::DOMException const& e)
+    catch(DOM::DOMException e)
     {
-        kdDebug(25001)<< "kafkaCommon::insertDomNode() - ERROR code :" << e.code << endl;
+      kdDebug(25001)<< "kafkaCommon::insertDomNode() - ERROR code :" << e.code << endl;
     }
     return true;
 }
[prev in list] [next in list] [prev in thread] [next in thread]