[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/work/kviewshell-0.7/kviewshell
From:       Stefan Kebekus <kebekus () kde ! org>
Date:       2006-05-15 19:20:00
Message-ID: 1147720800.665415.12837.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 541221 by kebekus:

switched off debugging messages


 M  +9 -0      TODO  
 M  +6 -4      shell/documentPageCache.cpp  
 M  +12 -3     shell/renderQueue.cpp  
 M  +9 -1      shell/renderThread.cpp  
 M  +1 -1      shell/renderedDocumentPagePixmap.cpp  


--- branches/work/kviewshell-0.7/kviewshell/TODO #541220:541221
@@ -27,6 +27,15 @@
 
 * support attached files
 
+
+SHELL
+
+* Problem: take a DJVU file, make bookmarks, delete some pages (->
+bookmarks change), then close without saving the file. The changed
+bookmarks will be saved.
+
+
+
 ====================
 
 CONSTRUCTION SITE
--- branches/work/kviewshell-0.7/kviewshell/shell/documentPageCache.cpp \
#541220:541221 @@ -440,14 +440,16 @@
     // Safety check
     if (page)
     {
+#ifdef documentPageCache_DEBUG
       kdDebug(kvs::shell) << "add rendered page to cache." << endl;
+#endif
     }
     else
     {
-      kdError() << "finished queue was empty." << endl;
+      kdError(kvs::shell) << "finished queue was empty." << endl;
       return;
     }
-
+    
     // Paint image to the page
     page->paintImage();
 
@@ -504,11 +506,11 @@
   {
     kdError(kvs::shell) << "DocumentPageCache::getPage(): inserting pagestructure \
into the cache failed.\n  This should never happen. If you see this message, \
something is very wrong." << endl;  }
-  #ifdef documentPageCache_DEBUG
+#ifdef documentPageCache_DEBUG
   kdDebug(kvs::shell) << "current cache size = " << LRUCache.totalCost() << endl
                       << "maximal cache size = " << LRUCache.maxCost() << endl
                       << "items in the cache = " << LRUCache.count() << endl;
-  #endif
+#endif
 }
 
 
--- branches/work/kviewshell-0.7/kviewshell/shell/renderQueue.cpp #541220:541221
@@ -27,6 +27,8 @@
 #include "renderedDocumentPagePixmap.h"
 #include "renderQueue.h"
 
+//#define RQ_DEBUG
+
 RenderQueue::RenderQueue(QObject* parent)
   : QObject(parent), mutex(true)
 {
@@ -74,7 +76,9 @@
       // TODO use equality operator
       if (queuedPage->getId() == page->getId())
       {
-        kdDebug() << "move sheduled request for page " << page->getPageNumber() << " \
to the front of the rendering queue." << endl; +#ifdef RQ_DEBUG
+        kdDebug(kvs::shell) << "move sheduled request for page " << \
page->getPageNumber() << " to the front of the rendering queue." << endl; +#endif
         // Move the page to front of the queue.
         it = renderQueue.erase(it);
         delete queuedPage;
@@ -92,7 +96,9 @@
 
   PageNumber pageNumber = page->getPageNumber();
 
-  kdDebug() << "add finised page " << pageNumber << endl;
+#ifdef RQ_DEBUG
+  kdDebug(kvs::shell) << "add finished page " << pageNumber << endl;
+#endif
 
   pendingQueue.remove(page->getId());
 
@@ -128,7 +134,10 @@
 
 void RenderQueue::wakeRenderThread()
 {
-  kdDebug() << "awake render thread" << endl;
+#ifdef RQ_DEBUG
+  kdDebug(kvs::shell) << "awake render thread" << endl;
+#endif
+
   itemAdded.wakeAll();
 }
 
--- branches/work/kviewshell-0.7/kviewshell/shell/renderThread.cpp #541220:541221
@@ -29,6 +29,8 @@
 #include "kvs_debug.h"
 #include "renderedDocumentPage.h"
 
+//#define RENDERTTHREAD_DEBUG
+
 RenderThread::RenderThread(RenderQueue* queue)
   : QThread(), stopRequested(false), renderQueue(queue)
 {
@@ -72,7 +74,9 @@
 
     if (!page)
     {
-      kdDebug() << "render thread wait" << endl;
+#ifdef RENDERTTHREAD_DEBUG
+      kdDebug(kvs::shell) << "render thread wait" << endl;
+#endif
       renderQueue->waitForItems(&renderMutex);
     }
     else
@@ -80,8 +84,10 @@
       // Safety check
       if (renderer.isNull())
       {
+#ifdef RENDERTTHREAD_DEBUG
         kdDebug(kvs::shell) << "RenderThread : renderer is null" << endl;
         kdDebug(kvs::shell) << "rendering thread terminated abnormally." << endl;
+#endif
         renderMutex.unlock();
 
         return;
@@ -100,5 +106,7 @@
     }
     renderMutex.unlock();
   }
+#ifdef RENDERTTHREAD_DEBUG
   kdDebug(kvs::shell) << "rendering thread finished" << endl;
+#endif
 }
--- branches/work/kviewshell-0.7/kviewshell/shell/renderedDocumentPagePixmap.cpp \
#541220:541221 @@ -203,7 +203,7 @@
 {
   if (!_image.isNull())
   {
-    kdDebug() << "RenderedDocumentPagePixmap::paintImage()" << endl;
+    //    kdDebug() << "RenderedDocumentPagePixmap::paintImage()" << endl;
     pagePixmap.convertFromImage(_image);
     dirty = true;
     _image.reset();


[prev in list] [next in list] [prev in thread] [next in thread]