[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdenetwork/kopete/kopete/contactlist
From:       Dirk Mueller <mueller () kde ! org>
Date:       2006-05-15 16:40:22
Message-ID: 1147711222.996065.22073.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 541142 by mueller:

fix crash (CID 2159)


 M  +9 -4      kopetecontactlistview.cpp  


--- branches/KDE/3.5/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp #541141:541142
@@ -135,10 +135,15 @@
 	template<typename GroupViewItem>
 	void removeMetaContactFromGroupInner( Kopete::MetaContact *mc, GroupViewItem *gpi )
 	{
-		for( QListViewItem *item = gpi->firstChild(); item; item = item->nextSibling() )
-			if ( KopeteMetaContactLVI *mci = dynamic_cast<KopeteMetaContactLVI*>(item) )
-				if ( mci->metaContact() == mc )
-					delete mci;
+	    KopeteMetaContactLVI* mci;
+        QListViewItem* item = gpi->firstChild();
+        while(item) {
+            mci = dynamic_cast<KopeteMetaContactLVI*>(item);
+	        item = item->nextSibling();
+
+			if ( mci && mci->metaContact() == mc )
+			    delete mci;
+	    }
 	}
 
 private:
[prev in list] [next in list] [prev in thread] [next in thread]