[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kio/kio
From:       David Faure <faure () kde ! org>
Date:       2006-05-11 9:49:53
Message-ID: 1147340993.531013.18804.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 539633 by dfaure:

Remove confusing debug output and add comment. No bug here.


 M  +4 -3      kservicefactory.cpp  


--- trunk/KDE/kdelibs/kio/kio/kservicefactory.cpp #539632:539633
@@ -149,10 +149,11 @@
    KService::Ptr newService(createEntry(offset));
    if ( !newService )
       qDebug( "findServiceByDesktopPath: createEntry failed!" );
-   // Check whether the dictionary was right.
+   // Check whether the dictionary was right
+   // It's ok that it's wrong, for the case where we're looking up an unknown \
service, +   // and the hash value gave us another one.
    if (newService && (newService->desktopEntryPath() != _name))
    {
-       qDebug( "the dictionary was wrong. desktopEntryPath=%s, name=%s", qPrintable( \
newService->desktopEntryPath() ), qPrintable( _name ) );  // No it wasn't...
       return KService::Ptr();
    }
@@ -279,7 +280,7 @@
             }
             // Restore position
             str->device()->seek( savedPos );
-         } else if ( aServiceTypeOffset > (qint32)serviceTypeOffset )
+         } else if ( aServiceTypeOffset > serviceTypeOffset )
             break; // too far
       }
       else


[prev in list] [next in list] [prev in thread] [next in thread]