[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/work/kde4/playground/libs/qt-dbus
From:       Thiago Macieira <thiago () kde ! org>
Date:       2006-05-06 10:35:26
Message-ID: 1146911726.338763.28625.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 537954 by thiago:

gcc 3.4 doesn't like Q_FOREACH when the list is a const-reference

 M  +1 -1      qdbusintegrator.cpp  
 M  +1 -1      qdbusmessage.cpp  
 M  +2 -2      qdbustypehelper_p.h  


--- branches/work/kde4/playground/libs/qt-dbus/qdbusintegrator.cpp #537953:537954
@@ -1097,7 +1097,7 @@
                 return true;
             }
 
-            const QObjectList &children = obj->children();
+            const QObjectList children = obj->children();
 
             // find a child with the proper name
             QObject *next = 0;
--- branches/work/kde4/playground/libs/qt-dbus/qdbusmessage.cpp #537953:537954
@@ -665,7 +665,7 @@
     dbg.nospace() << ")";
 }    
 
-static void debugVariantList(QDebug dbg, const QVariantList &list)
+static void debugVariantList(QDebug dbg, const QVariantList list)
 {
     bool first = true;
     foreach (const QVariant &v, list) {
--- branches/work/kde4/playground/libs/qt-dbus/qdbustypehelper_p.h #537953:537954
@@ -119,7 +119,7 @@
         return Type();
     }
 
-    static inline QVariantList toVariantList(const List &list)
+    static inline QVariantList toVariantList(const List list)
     {
         QVariantList tmp;
         Q_FOREACH (const Type &t, list)
@@ -132,7 +132,7 @@
         return toVariantList(QDBusTypeHelper<List>::fromVariant(v));
     }
 
-    static inline List fromVariantList(const QVariantList &list)
+    static inline List fromVariantList(const QVariantList list)
     {
         List tmp;
         Q_FOREACH (const QVariant &v, list)
[prev in list] [next in list] [prev in thread] [next in thread]