[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase
From:       André_Wöbbeking <Woebbeking () onlinehome ! de>
Date:       2006-04-30 14:13:52
Message-ID: 200604301613.52744.Woebbeking () onlinehome ! de
[Download RAW message or body]

On Sunday 30 April 2006 08:14, Stephan Kulow wrote:
> Am Samstag, 29. April 2006 08:12 schrieb André Wöbbeking:
> > On Friday 28 April 2006 23:30, Thorsten Roeder wrote:
> > > SVN commit 535225 by troeder:
> > >
> > > avoid unnecessary conversion: QPixmap->QImage->QPixmap
> > >
> > >
> > >  M  +2 -2      apps/konsole/konsole/konsole.cpp
> > >  M  +1 -1      kdcop/kdcopwindow.cpp
> > >  M  +1 -1      nsplugins/viewer/nsplugin.cpp
> > >  M  +1 -1      workspace/kwin/clients/default/kdedefault.cpp
> > >  M  +1 -1      workspace/kwin/clients/plastik/plastikbutton.cpp
> > >  M  +1 -1      workspace/kwin/clients/quartz/quartz.cpp
> > >
> > >
> > > --- trunk/KDE/kdebase/apps/konsole/konsole/konsole.cpp
> > > #535224:535225 @@ -3209,9 +3209,9 @@
> > >
> > >      // make sure they are not larger than 16x16
> > >      if (normal.width() > 16 || normal.height() > 16)
> > > -        normal =
> > > QPixmap::fromImage(normal.toImage().scaled(16,16,
> > > Qt::IgnoreAspectRatio, Qt::SmoothTransformation));
> > > +	normal.scaled(16,16, Qt::IgnoreAspectRatio,
> > > Qt::SmoothTransformation); if (active.width() > 16 ||
> > > active.height()
> > >
> > > > 16)
> >
> > QPixmap::scaled() doesn't change a pixmap but returns a new one.
>
> Isn't there some gcc attribute to mark a function that needs its
> return value to be used? This would be very useful here.

Don't know but there must be compilers supporting this as some people 
write e.g.

  (void) new QListViewItem(...)

to suppress such a warning.

[prev in list] [next in list] [prev in thread] [next in thread]