[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/khotkeys/kcontrol
From:       Luboš Luňák <l.lunak () kde ! org>
Date:       2006-04-19 11:40:24
Message-ID: 1145446824.589218.7430.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 531466 by lunakl:

Fix memory leaks.



 M  +6 -11     action_list_widget.cpp  


--- trunk/KDE/kdebase/khotkeys/kcontrol/action_list_widget.cpp #531465:531466
@@ -118,24 +118,19 @@
     switch( type_P )
         {
         case TYPE_COMMAND_URL_ACTION: // Command_url_action_dialog
-            dlg = new Command_url_action_dialog(
-                new Command_url_action( NULL, "" )); // CHECKME NULL ?
+            dlg = new Command_url_action_dialog( NULL );
           break;
         case TYPE_MENUENTRY_ACTION: // Menuentry_action_dialog
-            dlg = new Menuentry_action_dialog(
-                new Menuentry_action( NULL, "" )); // CHECKME NULL ?
+            dlg = new Menuentry_action_dialog( NULL );
           break;
         case TYPE_DCOP_ACTION: // Dcop_action_dialog
-            dlg = new Dcop_action_dialog(
-                new Dcop_action( NULL, "", "", "", "" ));
+            dlg = new Dcop_action_dialog( NULL );
           break;
         case TYPE_KEYBOARD_INPUT_ACTION: // Keyboard_input_action_dialog
-            dlg = new Keyboard_input_action_dialog(
-                new Keyboard_input_action( NULL, "", NULL, false )); // CHECKME NULL ?
+            dlg = new Keyboard_input_action_dialog( NULL );
           break;
         case TYPE_ACTIVATE_WINDOW_ACTION: // Activate_window_action_dialog
-            dlg = new Activate_window_action_dialog(
-                new Activate_window_action( NULL, new Windowdef_list( "" )));
+            dlg = new Activate_window_action_dialog( NULL );
           break;
         default:
           assert( false );
@@ -333,7 +328,7 @@
     : KDialogBase( NULL, NULL, true, "", Ok | Cancel ), action( NULL ) // CHECKME caption
     {
     widget = new Activate_window_widget( this );
-    widget->set_data( action_P->window());
+    widget->set_data( action_P ? action_P->window() : NULL );
     setMainWidget( widget );
     }
 
[prev in list] [next in list] [prev in thread] [next in thread]