[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdelibs/khtml/html
From:       George Staikos <staikos () kde ! org>
Date:       2006-04-03 7:12:45
Message-ID: 1144048365.404384.12410.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 525884 by staikos:

I'm not sure why this crash is happening (part = 0), but kwallet really
shouldn't be crashing KHTML and we'd better avoid it at all costs.

Any comments before I put it into trunk?


 M  +3 -1      html_formimpl.cpp  


--- branches/KDE/3.5/kdelibs/khtml/html/html_formimpl.cpp #525883:525884
@@ -630,7 +630,9 @@
                     // otherwise we might have a potential security problem
                     // by saving passwords under wrong lookup key.
 
-                    getDocument()->view()->part()->saveToWallet(key, m_walletMap);
+                    if (view->part()) {
+                        view->part()->saveToWallet(key, m_walletMap);
+                    }
                 } else if ( savePassword == KDialogBase::No ) {
                     view->addNonPasswordStorableSite(formUrl.host());
                 }
[prev in list] [next in list] [prev in thread] [next in thread]