[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/work/khtml-svg/svg
From:       Rob Buis <buis () kde ! org>
Date:       2006-04-01 20:16:11
Message-ID: 1143922571.691328.13319.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 525374 by buis:

Finally <use> should work.


 M  +1 -1      SVGStyledElementImpl.h  
 M  +10 -12    SVGURIReferenceImpl.cpp  


--- branches/work/khtml-svg/svg/SVGStyledElementImpl.h #525373:525374
@@ -54,7 +54,7 @@
         virtual DOM::CSSValueImpl *getPresentationAttribute(const DOM::DOMString \
&name);  
         // This needs to be implemented.
-        virtual bool rendererIsNeeded(khtml::RenderStyle *style) { return false; }
+        virtual bool rendererIsNeeded(khtml::RenderStyle *) { return false; }
         virtual KCanvasPath *toPathData() const { return 0; }
         virtual khtml::RenderObject *createRenderer(khtml::RenderArena *arena, \
khtml::RenderStyle *style);  virtual KCanvasResource *canvasResource() { return 0; }
--- branches/work/khtml-svg/svg/SVGURIReferenceImpl.cpp #525373:525374
@@ -45,19 +45,17 @@
 
 bool SVGURIReferenceImpl::parseAttribute(DOM::AttributeImpl *attr)
 {
-	DOM::DOMString value = attr->value();
+    DOM::DOMString value = attr->value();
+    // TODO : maybe the xlink check can be done more elegantly, do
+	// we need xlink namespace? (Rob)
+    if(attr->id() == ATTR_HREF || attr->name() == "xlink:href")
+    {
+        int ignoreException;
+        href()->setBaseVal(value.implementation(), ignoreException);
+        return true;
+    }
 
-	switch(attr->id())
-	{
-		case ATTR_HREF:
-		{
-			int ignoreException;
-			href()->setBaseVal(value.implementation(), ignoreException);
-			return true;
-		}
-		default:
-			return false;
-	}
+    return false;
 }
 
 QString SVGURIReferenceImpl::getTarget(const QString &url)


[prev in list] [next in list] [prev in thread] [next in thread]